Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

histogram: rename serde feature #95

Merged
merged 4 commits into from
Jan 16, 2024
Merged

histogram: rename serde feature #95

merged 4 commits into from
Jan 16, 2024

Conversation

brayniac
Copy link
Contributor

Renames the serde feature to better match conventions.

@brayniac brayniac requested a review from swlynch99 January 16, 2024 23:11
swlynch99
swlynch99 requested changes Jan 16, 2024
View reviewed changes
Copy link
Contributor

@swlynch99 swlynch99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to fix the uses of the feature name too?

I'm pretty sure there's some #[cfg_attr(feature = "serde-serialize", ..)] in the crates that needs to be changed.

@brayniac
histogram: rename serde feature
a9cede7 
Renames the serde feature to better match conventions.
swlynch99
swlynch99 approved these changes Jan 16, 2024
View reviewed changes
Copy link
Contributor

@swlynch99 swlynch99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I was worried that this might be a breaking change in metriken but cargo-semver-checks seems to be ok with it so we should be good to go.

@brayniac brayniac merged commit 5b22527 into pelikan-io:main Jan 16, 2024
15 checks passed
@brayniac brayniac deleted the histogram-features branch January 16, 2024 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swlynch99 swlynch99 swlynch99 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brayniac @swlynch99