Support datetime + URL settings that strip the leading zero #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinmayer
requested changes
Jul 13, 2021
There was a problem hiding this comment.
Nice work! I made a few minor suggestions. Regarding the Black-related changes, I think those are better submitted in a separate pull request since they seem to be unrelated to the objective of this PR.
I updated linter versions in master, so I recommend dropping the 69e3e7b commit and rebasing this PR on master.
…rl has "{date:%-d}"
This relies on customized strftime behaviour built into Pelican.
Also, adds tests!
MinchinWeb
force-pushed
the
error-logging
branch
from
cd7341a to
4e0e507
Compare
Update format (and Changelog format) as per review notes
MinchinWeb
force-pushed
the
error-logging
branch
from
4e0e507 to
5b06da3
Compare
|
@justinmayer Updated, and ready to go! |
justinmayer
approved these changes
Jul 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building on the groundwork of getpelican/pelican#2902, this aims to support Pelican's custom strftime implementation to allow striping of leading zeros.
Also, it adds better logging for when a filter errors out or pre-commit black does.
Also adds a couple more tests.