Add hint about overhead when using memory limit #1069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Boy132
reviewed
Mar 8, 2025
Co-authored-by: Boy132 <Boy132@users.noreply.github.com>
lancepioch
reviewed
Mar 8, 2025
| @@ -36,6 +36,7 @@ | |||
| 'disabled' => 'Disabled', | |||
| 'memory' => 'Memory', | |||
| 'memory_limit' => 'Memory Limit', | |||
| 'memory_helper' => 'Wings will add overhead to this value when creating the container to make sure it doesn\'t starve out when using max memory.', | |||
There was a problem hiding this comment.
Rewrite
Suggested change
| 'memory_helper' => 'Wings will add overhead to this value when creating the container to make sure it doesn\'t starve out when using max memory.', | |
| 'memory_helper' => 'While the Server is being created, additional memory will be temporarily used to help prevent issues.', |
There was a problem hiding this comment.
That description is wrong. The overhead is added to the normal container, not the install container.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add hint about overhead as it's not documented anywhere except in the wings source code.