Officially support PostgreSQL database #1066
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmartinoscar
reviewed
Mar 8, 2025
rmartinoscar
reviewed
Mar 8, 2025
rmartinoscar
reviewed
Mar 8, 2025
database/migrations/2017_11_19_122708_MigratePubPrivFormatToSingleKey.php
Show resolved
Hide resolved
|
Do changing all these migrations break new installs for SQLite and MySQL? |
| @@ -14,7 +14,7 @@ public function up(): void | |||
| $table->string('id')->primary(); | |||
| $table->string('type'); | |||
| $table->morphs('notifiable'); | |||
| $table->text('data'); | |||
| $table->json('data'); | |||
There was a problem hiding this comment.
Postgres should basically never use json. Always jsonb. There's a bunch of JSON operations in the code that depend on the database being able to understand the JSON, which is impossible with json.
rmartinoscar
reviewed
Mar 9, 2025
| @@ -33,6 +33,13 @@ protected function getFormActions(): array | |||
| return []; | |||
| } | |||
|
|
|||
| protected function prepareForValidation($attributes): array | |||
| { | |||
| $attributes['data']['email'] = strtolower($attributes['data']['email']); | |||
There was a problem hiding this comment.
Suggested change
| $attributes['data']['email'] = strtolower($attributes['data']['email']); | |
| $attributes['data']['email'] = mb_strtolower($attributes['data']['email']); |
rmartinoscar
reviewed
Mar 9, 2025
| @@ -179,6 +179,10 @@ protected static function booted(): void | |||
| return true; | |||
| }); | |||
|
|
|||
| static::saving(function (self $user) { | |||
| $user->email = strtolower($user->email); | |||
There was a problem hiding this comment.
Suggested change
| $user->email = strtolower($user->email); | |
| $user->email = mb_strtolower($user->email); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.