Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update popularity value from 'misc:photo_sum' to 'qs:photo_sum' #547

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update popularity value from 'misc:photo_sum' to 'qs:photo_sum' #547

wants to merge 2 commits into from

Conversation

arnesetzer
Copy link

@arnesetzer arnesetzer commented Aug 23, 2024 •
edited
Loading

👋 I did some awesome work for the Pelias project and would love for everyone to have a look at it and provide feedback.

Here's the reason for this change 🚀

Since 2018 the property misc:photo_sum is deprecated and has been moved to qs:photo_sum.

Here's what actually got changed 👏

  • Add a function to handle legacy data prior 2018.
  • Update the belonging test

Here's how others can test the changes 👀

Run the tests. They are updated to the current data schema as well.

@arnesetzer arnesetzer marked this pull request as ready for review August 23, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@arnesetzer