Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added continent as a parent field #48

Merged
merged 1 commit into from
Dec 5, 2016
Merged

Added continent as a parent field #48

merged 1 commit into from
Dec 5, 2016

Conversation

cag
Copy link

@cag cag commented Dec 3, 2016

For this: pelias/pelias#473

@orangejulius
Copy link
Member

While your at it, using git rebase to squash these two commits would be great as well. Extra commits to fix tests passing and whatnot just clutter up the git history, so while it's not a huge deal we like to avoid them where we can. Thanks!

@cag
Copy link
Author

cag commented Dec 5, 2016

Alright, done. I'll try to improve my gitiquette in the future :P

@orangejulius
Copy link
Member

Excellent, looks good.

@orangejulius orangejulius merged commit ca3efbf into pelias:master Dec 5, 2016
orangejulius added a commit to pelias/schema that referenced this pull request May 1, 2018
@orangejulius
Add continent to mapping
8e5f2d2 
We added continents to pelias/model in pelias/model#48,
so our importers now ask Elasticsearch to create records with fields for
continents.

At the moment, looking at pelias/pelias#473
and associated issues, it doesn't appear we ever add any date to the
continent fields. Whether or not we want to do that is worth discussing.

However, without adding continents to the Elasticsearch mapping,
Elasticsearch will add all of these continent fields as string mappings:

```
julian@manhattan ~/repos/pelias/schema $ curl -s localhost:9200/pelias | jq . | grep continent -C 3
                "store": true,
                "analyzer": "keyword"
              },
              "continent": {
                "type": "string"
              },
              "continent_id": {
                "type": "string"
              },

```

This isn't ideal, even if no continents are ever added to the index.
@orangejulius orangejulius mentioned this pull request May 1, 2018
Merged
orangejulius added a commit to pelias/schema that referenced this pull request May 3, 2018
@orangejulius
Add continent to mapping
0517d0d 
We added continents to pelias/model in pelias/model#48,
so our importers now ask Elasticsearch to create records with fields for
continents.

At the moment, looking at pelias/pelias#473
and associated issues, it doesn't appear we ever add any date to the
continent fields. Whether or not we want to do that is worth discussing.

However, without adding continents to the Elasticsearch mapping,
Elasticsearch will add all of these continent fields as string mappings:

```
julian@manhattan ~/repos/pelias/schema $ curl -s localhost:9200/pelias | jq . | grep continent -C 3
                "store": true,
                "analyzer": "keyword"
              },
              "continent": {
                "type": "string"
              },
              "continent_id": {
                "type": "string"
              },

```

This isn't ideal, even if no continents are ever added to the index.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orangejulius orangejulius orangejulius approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cag @orangejulius @dianashk