Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add geonames postal code - need improvement #396

Closed
wants to merge 1 commit into from
Closed

add geonames postal code - need improvement #396

wants to merge 1 commit into from

Conversation

imcristin
Copy link

👋 I did some awesome work for the Pelias project and would love for everyone to have a look at it and provide feedback.


Here's the reason for this change 🚀


Here's what actually got changed 👏


Here's how others can test the changes 👀

@missinglink
Copy link
Member

missinglink commented Aug 13, 2021

Thanks for the PR, what's your impression of the quality of the data?

There was a discussion in the past about it and IIRC the postcodes were not very accurate in some countries. see #358

We usually recommend importing postcodes from the whosonfirst dataset such as https://github.com/whosonfirst-data/whosonfirst-data-postalcode-us which we find to be better quality.

@imcristin
Copy link
Author

Thanks for the PR, what's your impression of the quality of the data?

There was a discussion in the past about it and IIRC the postcodes were not very accurate in some countries. see #358

We usually recommend importing postcodes from the whosonfirst dataset such as https://github.com/whosonfirst-data/whosonfirst-data-postalcode-us which we find to be better quality.

I think that 4 digits are enough for the coordinates of the locality.
Whosonfirst does not have zip codes for all countries, while geonames has.
The problem with geonames is that localities are not indexed with geonames. Who's on First Admin Lookup does not work in localities

@InteNs
Copy link

InteNs commented Nov 11, 2021

i would love to test this importer for the NL_full.csv.zip file, can we push an image with this branch?

@missinglink
Copy link
Member

The docker images are not being automatically generated for this branch because it comes from a fork.
You can generate the docker image yourself by cloning the fork, checking out the branch and running this command in the root of this repo:

docker build -t pelias/geonames:postalcode .

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants