Merge staging into production #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The mystery of metadata from #222 has been solved! It turns out npm postinstall hooks, which we use to download the metadata, do not fire when `DEBIAN_FRONTEND=noninteractive` is set in the shell, such as we do in our Docker [baseimage](https://github.com/pelias/dockerfiles/blob/master/baseimage/Dockerfile#L8). This explains why the metadata downloads fine on local machines and in the Chef Mapzen Search environment, but not in Kubernetes. It also doesn't work in the Docker image in general. This PR adds an explicit `npm run download_metadata` to the Dockerfile, so that the Docker images contain this metadata, solving any Docker or Kubernetes issues. Additionally, it updates the readme to both clarify the situation in the metadata documentation section, and remove it from the main install instructions (since under normal interactive shell sessions it is _not_ required and would just be an extra step). Fixes #222 Connects #223
Explicitly handle metadata in Docker and update Documentation
Update pelias-config to the latest version 🚀
fix(package): update pelias-model to version 5.3.2
…-lookup-4.5.2 fix(package): update pelias-wof-admin-lookup to version 4.5.2
Update pelias-logger to the latest version 🚀
…2.3.1 Update pelias-dbclient to the latest version 🚀
…-lookup-4.5.4 fix(package): update pelias-wof-admin-lookup to version 4.5.4
…2.4.0 Update pelias-dbclient to the latest version 🚀
Merge master into staging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request has been automatically generated by repo-walker.