Upgrade to Node.js 16.20.1 #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orangejulius
force-pushed
the
nodejs-16
branch
from
8ee3ae2
to
286f2e8
Compare
|
Sounds good to me. If any downstream consumers break as a result, we should catch those errors in their CI, so I feel it's safe to merge and begin deploying to other Pelias repos. |
missinglink
approved these changes
Jul 3, 2023
orangejulius
added a commit
to pelias/api
that referenced
this pull request
Jul 3, 2023
This is just for testing to ensure everything works before we merge pelias/docker-baseimage#24
orangejulius
added a commit
to pelias/pip-service
that referenced
this pull request
Jul 3, 2023
This is just for testing to ensure everything works before we merge pelias/docker-baseimage#24
orangejulius
added a commit
to pelias/libpostal-service
that referenced
this pull request
Jul 3, 2023
This is just for testing to ensure everything works before we merge pelias/docker-baseimage#24
orangejulius
added a commit
to pelias/docker-libpostal_baseimage
that referenced
this pull request
Jul 3, 2023
This is just for testing to ensure everything works before we merge pelias/docker-baseimage#24
orangejulius
added a commit
to pelias/placeholder
that referenced
this pull request
Jul 3, 2023
This is just for testing to ensure everything works before we merge pelias/docker-baseimage#24
orangejulius
added a commit
to pelias/schema
that referenced
this pull request
Jul 3, 2023
This is just for testing to ensure everything works before we merge pelias/docker-baseimage#24
orangejulius
added a commit
to pelias/schema
that referenced
this pull request
Jul 3, 2023
This is just for testing to ensure everything works before we merge pelias/docker-baseimage#24
orangejulius
added a commit
to pelias/docker-libpostal_baseimage
that referenced
this pull request
Jul 4, 2023
This is just for testing to ensure everything works before we merge pelias/docker-baseimage#24
orangejulius
added a commit
to pelias/libpostal-service
that referenced
this pull request
Jul 4, 2023
This is just for testing to ensure everything works before we merge pelias/docker-baseimage#24
orangejulius
added a commit
to pelias/interpolation
that referenced
this pull request
Jul 4, 2023
This is just for testing to ensure everything works before we merge pelias/docker-baseimage#24
orangejulius
added a commit
to pelias/openstreetmap
that referenced
this pull request
Jul 4, 2023
This is just for testing to ensure everything works before we merge pelias/docker-baseimage#24
orangejulius
added a commit
to pelias/whosonfirst
that referenced
this pull request
Jul 4, 2023
This is just for testing to ensure everything works before we merge pelias/docker-baseimage#24
orangejulius
added a commit
to pelias/openaddresses
that referenced
this pull request
Jul 4, 2023
This is just for testing to ensure everything works before we merge pelias/docker-baseimage#24
orangejulius
added a commit
to pelias/polylines
that referenced
this pull request
Jul 4, 2023
This is just for testing to ensure everything works before we merge pelias/docker-baseimage#24
orangejulius
added a commit
to pelias/geonames
that referenced
this pull request
Jul 4, 2023
This is just for testing to ensure everything works before we merge pelias/docker-baseimage#24
orangejulius
added a commit
to pelias/transit
that referenced
this pull request
Jul 4, 2023
This is just for testing to ensure everything works before we merge pelias/docker-baseimage#24
orangejulius
added a commit
to pelias/csv-importer
that referenced
this pull request
Jul 4, 2023
This is just for testing to ensure everything works before we merge pelias/docker-baseimage#24
orangejulius
pushed a commit
to pelias/interpolation
that referenced
this pull request
Jul 4, 2023
orangejulius
added a commit
to pelias/interpolation
that referenced
this pull request
Jul 4, 2023
This is just for testing to ensure everything works before we merge pelias/docker-baseimage#24
|
Okay, all our repositories with Docker images (services, importers, schema, etc) now build and pass tests both with their current configuration and with Node.js 16, so it's time to merge this. We can then merge PRs to update dependencies, etc to support higher Node.js versions. We can also drop Node.js 12 from all our CI matricies. |
orangejulius
added a commit
to pelias/docker-libpostal_baseimage
that referenced
this pull request
Jul 4, 2023
This is an empty commit that serves only to tell our CI to build new Docker images now that we have merged pelias/docker-baseimage#24 and move the default Node.js version from 12 to 16 Connects pelias/pelias#950
orangejulius
added a commit
to pelias/docker-libpostal_baseimage
that referenced
this pull request
Jul 4, 2023
This is an empty commit that serves only to tell our CI to build new Docker images now that we have merged pelias/docker-baseimage#24 and move the default Node.js version from 12 to 16 Connects pelias/pelias#950
orangejulius
added a commit
to pelias/docker-libpostal_baseimage
that referenced
this pull request
Jul 4, 2023
This is an empty commit that serves only to tell our CI to build new Docker images now that we have merged pelias/docker-baseimage#24 and move the default Node.js version from 12 to 16 Connects pelias/pelias#950
orangejulius
added a commit
to pelias/schema
that referenced
this pull request
Jul 4, 2023
This is an empty commit that serves only to tell our CI to build new Docker images now that we have merged pelias/docker-baseimage#24 and move the default Node.js version from 12 to 16 Connects pelias/pelias#950
orangejulius
added a commit
to pelias/openstreetmap
that referenced
this pull request
Jul 4, 2023
This is an empty commit that serves only to tell our CI to build new Docker images now that we have merged pelias/docker-baseimage#24 and move the default Node.js version from 12 to 16 Connects pelias/pelias#950
orangejulius
added a commit
to pelias/whosonfirst
that referenced
this pull request
Jul 4, 2023
This is an empty commit that serves only to tell our CI to build new Docker images now that we have merged pelias/docker-baseimage#24 and move the default Node.js version from 12 to 16 Connects pelias/pelias#950
orangejulius
added a commit
to pelias/openaddresses
that referenced
this pull request
Jul 4, 2023
This is an empty commit that serves only to tell our CI to build new Docker images now that we have merged pelias/docker-baseimage#24 and move the default Node.js version from 12 to 16 Connects pelias/pelias#950
orangejulius
added a commit
to pelias/polylines
that referenced
this pull request
Jul 4, 2023
This is an empty commit that serves only to tell our CI to build new Docker images now that we have merged pelias/docker-baseimage#24 and move the default Node.js version from 12 to 16 Connects pelias/pelias#950
orangejulius
added a commit
to pelias/geonames
that referenced
this pull request
Jul 4, 2023
This is an empty commit that serves only to tell our CI to build new Docker images now that we have merged pelias/docker-baseimage#24 and move the default Node.js version from 12 to 16 Connects pelias/pelias#950
orangejulius
added a commit
to pelias/transit
that referenced
this pull request
Jul 4, 2023
This is an empty commit that serves only to tell our CI to build new Docker images now that we have merged pelias/docker-baseimage#24 and move the default Node.js version from 12 to 16 Connects pelias/pelias#950
orangejulius
added a commit
to pelias/csv-importer
that referenced
this pull request
Jul 4, 2023
This is an empty commit that serves only to tell our CI to build new Docker images now that we have merged pelias/docker-baseimage#24 and move the default Node.js version from 12 to 16 Connects pelias/pelias#950
orangejulius
added a commit
to pelias/api
that referenced
this pull request
Jul 4, 2023
This is an empty commit that serves only to tell our CI to build new Docker images now that we have merged pelias/docker-baseimage#24 and move the default Node.js version from 12 to 16 Connects pelias/pelias#950
orangejulius
added a commit
to pelias/placeholder
that referenced
this pull request
Jul 4, 2023
This is an empty commit that serves only to tell our CI to build new Docker images now that we have merged pelias/docker-baseimage#24 and move the default Node.js version from 12 to 16 Connects pelias/pelias#950
orangejulius
added a commit
to pelias/libpostal-service
that referenced
this pull request
Jul 4, 2023
This is an empty commit that serves only to tell our CI to build new Docker images now that we have merged pelias/docker-baseimage#24 and move the default Node.js version from 12 to 16 Connects pelias/pelias#950
orangejulius
added a commit
to pelias/interpolation
that referenced
this pull request
Jul 4, 2023
This is an empty commit that serves only to tell our CI to build new Docker images now that we have merged pelias/docker-baseimage#24 and move the default Node.js version from 12 to 16 Connects pelias/pelias#950
orangejulius
added a commit
to pelias/pip-service
that referenced
this pull request
Jul 4, 2023
This is an empty commit that serves only to tell our CI to build new Docker images now that we have merged pelias/docker-baseimage#24 and move the default Node.js version from 12 to 16 Connects pelias/pelias#950
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our Docker baseimage is currently on Node.js 12, the lowest version we support. It just entered LTS, so there's no real need to rush on removing it, but Node.js 16 has some nice new features and seemingly better performance.
We've been testing all our repositories on Node.js 16 so things should be pretty smooth. Before merging this I'll perform some additional testing.