-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Print specific error message #129
Merged
missinglink
merged 1 commit into
pelias:master
from
michaelkirk-pelias:mkirk/log-error-specifics
Jun 18, 2024
Merged
Print specific error message #129
missinglink
merged 1 commit into
pelias:master
from
michaelkirk-pelias:mkirk/log-error-specifics
Jun 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See pelias/docker#217 Currently users are seeing "elasticsearch index pelias does not exist" even though it does. This could happen if an error is encountered while making the request. We should print a more useful error message in that case.
Thanks! |
orangejulius
added a commit
to pelias/openstreetmap
that referenced
this pull request
Dec 3, 2024
This adds some new diagnostics for errors from pelias/dbclient#129
orangejulius
added a commit
to pelias/openstreetmap
that referenced
this pull request
Dec 3, 2024
This adds some new diagnostics for errors from pelias/dbclient#129
orangejulius
added a commit
to pelias/whosonfirst
that referenced
this pull request
Dec 3, 2024
This adds some new diagnostics for errors from pelias/dbclient#129
orangejulius
added a commit
to pelias/openaddresses
that referenced
this pull request
Dec 3, 2024
This adds some new diagnostics for errors from pelias/dbclient#129
orangejulius
added a commit
to pelias/polylines
that referenced
this pull request
Dec 3, 2024
This adds some new diagnostics for errors from pelias/dbclient#129
orangejulius
added a commit
to pelias/geonames
that referenced
this pull request
Dec 3, 2024
This adds some new diagnostics for errors from pelias/dbclient#129
orangejulius
added a commit
to pelias/transit
that referenced
this pull request
Dec 3, 2024
This adds some new diagnostics for errors from pelias/dbclient#129
orangejulius
added a commit
to pelias/csv-importer
that referenced
this pull request
Dec 3, 2024
This adds some new diagnostics for errors from pelias/dbclient#129
This was referenced Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's the reason for this change 🚀
See pelias/docker#217
Currently users are seeing "elasticsearch index pelias does not exist" even though it does exist.
This could happen if an error is encountered while making the request.
We should print a more useful error message in that case.
Here's what actually got changed 👏
We now check to see if
error
is set before consultingexists
.If
error
is set, thenexists
can't be trusted.Here's how others can test the changes 👀
Previously successful workflows should continue to succeed. Give them a try.
If you were experiencing a timeout with big planet builds, like in pelias/docker#217, this should get you a better error message.
Here's output of my running a failed planet import after these changes:
This is much more helpful than:
ERROR: Elasticsearch index pelias does not exist
which was downright misleading.