try/catch extent() #124
Merged
try/catch extent() #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add a block comment documenting why that |
| @@ -62,7 +62,12 @@ function search( docs, params ){ | |||
| var geojson = GeoJSON.parse( geodata, { Point: ['lat', 'lng'] }); | |||
|
|
|||
| // add bbox | |||
| geojson.bbox = extent( geojson ) || undefined; | |||
| try { | |||
| geojson.bbox = extent( geojson ) || undefined; | |||
There was a problem hiding this comment.
it looks a bit odd to have the || conditional inside a try/catch and after the thing that might throw. would be cleaner as
geojson.bbox = undefined;
try {
geojson.bbox = extent( geojson )
}
catch (e) {
// ...
}There was a problem hiding this comment.
yea, I think this is because extent() can return null which ends up in the JSON payload, I totally agree it doesn't feel right, will give it a rejig.
|
thanks for the rejig. 👍 |
|
+1 |
$ npm publish
npm http PUT https://registry.npmjs.org/pelias-api
npm http 200 https://registry.npmjs.org/pelias-api
+ pelias-api@1.2.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
try/catch for the issue causing pelias/pelias#84
updates dependency which should prevent the above try/catch from firing, issue should now be resolved.
ref: caseycesari/GeoJSON.js#12
resolves #84