Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for addresses with hyphens #503

Merged
merged 1 commit into from
Sep 12, 2019
Merged

Add tests for addresses with hyphens #503

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 42 additions & 0 deletions test_cases/address_parsing.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -363,6 +363,48 @@
}
]
}
},
{
"id": 11,
"status": "pass",
"issue": "https://github.com/pelias/schema/issues/65",
"user": "julian",
"in": {
"text": "Friedrich-Richter-Straße 51"
},
"expected": {
"properties": [
{
"housenumber": "51",
"street": "Friedrich-Richter-Straße",
"confidence": 1,
"match_type": "exact",
"accuracy": "point",
"locality": "Berlin"
}
]
}
},
{
"id": "11.1",
"status": "pass",
"issue": "https://github.com/pelias/schema/issues/65",
"user": "julian",
"in": {
"text": "Friedrich Richter Straße 51"
},
"expected": {
"properties": [
{
"housenumber": "51",
"street": "Friedrich-Richter-Straße",
"confidence": 1,
"match_type": "exact",
"accuracy": "point",
"locality": "Berlin"
}
]
}
}
]
}
40 changes: 40 additions & 0 deletions test_cases/french_addresses.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,25 @@
]
}
},
{
"id": "2-no-hyphen",
"status": "pass",
"user": "adefarge",
"type": "france",
"in": {
"text": "20 Boulevard Saint Martin, Paris"
},
"expected": {
"properties": [
{
"housenumber": "20",
"street": "Boulevard Saint-martin",
"locality": "Paris",
"country_a": "FRA"
}
]
}
},
{
"id": "2-abbrev",
"status": "fail",
Expand Down Expand Up @@ -304,6 +323,27 @@
}
]
}
},
{
"id": "11",
"status": "pass",
"user": "orangejulius",
"type": "france",
"description": "address without hyphens",
"issue": "https://github.com/pelias/api/pull/1268",
"in": {
"text": "20 boulevard saint germain, paris, france"
},
"expected": {
"properties": [
{
"housenumber": "20",
"street": "Boulevard Saint-Germain",
"locality": "Paris",
"country_a": "FRA"
}
]
}
}
]
}