This repository has been archived by the owner on Mar 6, 2019. It is now read-only.
Enable the Libpostal Service #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
orangejulius
force-pushed
the
libpostal-service
branch
2 times, most recently
from
11de864
to
9de04b0
Compare
orangejulius
added a commit
that referenced
this pull request
Mar 19, 2018
The Pelias API has now been modified to expect libpostal to live as a separate HTTP service rather than being included in memory. This PR adds the libpostal service to `docker-compose.yml` but doesn't change anything else. The current (as of 2018/3/19) `production` version of Pelias API does not yet use the libpostal service. It's convenient to have this merged so that we can start the process of switching over, though. Connects #42
orangejulius
added a commit
that referenced
this pull request
Mar 19, 2018
The Pelias API has now been modified to expect libpostal to live as a separate HTTP service rather than being included in memory. This PR adds the libpostal service to `docker-compose.yml` but doesn't change anything else. The current (as of 2018/3/19) `production` version of Pelias API does not yet use the libpostal service. It's convenient to have this merged so that we can start the process of switching over, though. Connects #42
Merged
|
I got stung with this today, seems the libpostal service code was already merged to master |
|
is it possible to change |
|
if the docker image is still not at approving, will let you decide what's best |
missinglink
approved these changes
Mar 22, 2018
orangejulius
force-pushed
the
libpostal-service
branch
from
9de04b0
to
e30a668
Compare
The Pelias API has now been modified to expect libpostal to live as a separate HTTP service rather than being included in memory.
orangejulius
force-pushed
the
libpostal-service
branch
from
e30a668
to
af9a74d
Compare
support for the libpostal service has not yet been merged to production, so we need this for now. It should be removed once libpostal support is stable
orangejulius
force-pushed
the
libpostal-service
branch
from
af9a74d
to
d0cb3fe
Compare
|
Okay, this has been open for a while, it's time to merge |
|
We will be merging the libpostal-service change to pelias-api to production/latest soon! |
orangejulius
added a commit
that referenced
this pull request
May 15, 2018
Now that pelias/api#1138 is merged, the Pelias API production images now use the Libpostal service, as described in pelias/api#1072. In #42 we said we would use the staging branch for the API in this repo until that merge happened. Now we can move back!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in pelias/api#1060 and pelias/api#1072, we have started converting Libpostal to its own service, rather than loading it into memory in the API service. This PR adds support for that in the dockerfiles.
It's ready to go immediately, although for now it will have to use an API docker image built off of the master branch.
I'd like to merge this before we merge the API changes for the libpostal service to the production branch, to ensure there's a seamless transition. Then we should go back and update the docker-compose.yml file to point to the production Docker images.