Ui integration #97
Ui integration #97
Conversation
…onfiguration and updated constellation deployment configuration files.
…onfiguration and updated constellation deployment configuration files.
…onfiguration and updated constellation deployment configuration files.
…ga-helm-charts into ui_integration
… it conditional and added respective tests.
…test to reflect it.
dcasavant
requested review from
MadhuriArugula,
dcasavant,
Max-Levitskiy and
pega-embate
There was a problem hiding this comment.
Added comments inline.
@pegasystems/deployment and @MadhuriArugula - can you take a look? Especially the tests to make sure they don't conflict with your recent work.
@nikhilparmar86 I think we could simplify the passing of the cosmos DSS a fair bit. Let me know if you want to discuss.
This chart is still called constellation, but it should probably be renamed to cosmosui.
charts/pega/charts/constellation/templates/clln-deployment.yaml
Outdated
Show resolved
Hide resolved
charts/pega/charts/constellation/templates/clln-deployment.yaml
Outdated
Show resolved
Hide resolved
|
Removing the values.yaml blocks per conversation with Nigel. Will merge this in a dormant state for now and submit one more PR once 8.5 is GA. Removed block to re-add later: # Pega constellation UI settings.
# Note : This node is for constellation service whose purpose is to serve static content to applications.
# This is a feature currently under development and is to be used only with Pega versions 8.5 and above.
constellation:
enabled: false |
dcasavant
dismissed
Max-Levitskiy’s stale review
There has been significant refactoring since this review. Can you take another look Max?
|
@Max-Levitskiy FYI |
| @@ -0,0 +1,36 @@ | |||
| #Deploy only when the constellation flag has been enabled in the values yaml. | |||
| {{ if and .Values.enabled (eq .Values.enabled true) }} | |||
There was a problem hiding this comment.
Probably, we shouldn't check boolean value with eq operator.
charts/pega/charts/constellation/templates/clln-deployment.yaml
Outdated
Show resolved
Hide resolved
| - backend: | ||
| serviceName: {{ .name }} | ||
| paths: | ||
| {{ if and .root.Values.constellation (eq .root.Values.constellation.enabled true) }} |
There was a problem hiding this comment.
this statement repeated multiple times. Should we extract it?
EPIC:59563, US-345810 : Modified the constellation deployment to make it conditional and added respective tests.