Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG-868079 Add the option to configure keystore and truststore type for Cassandra connection #769

Merged
merged 5 commits into from
Jul 22, 2024
Merged

BUG-868079 Add the option to configure keystore and truststore type for Cassandra connection #769

merged 5 commits into from
Jul 22, 2024

Conversation

wonim2022
Copy link
Contributor

…or cassandra client encryption

@wonim2022 wonim2022 requested a review from a team as a code owner June 5, 2024 09:33
@wonim2022 wonim2022 force-pushed the bugfix/BUG-868079-cassandra-store-type branch 4 times, most recently from 10553fc to 7a699ad Compare June 5, 2024 13:35
@wonim2022 wonim2022 changed the title BUG-868079 Add the option to configure keystore and truststore type f… BUG-868079 Add the option to configure keystore and truststore type for Cassandra connection Jun 25, 2024
taz-pega-work
taz-pega-work requested changes Jul 3, 2024
View reviewed changes
Copy link
Contributor

@taz-pega-work taz-pega-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For all of the newly added comments, we need Cassandra to be capitalized so these comments have Cassandra consistently capitalized across all of the files. Otherwise, I think the wording looks pretty good.

@wonim2022
Copy link
Contributor Author

Thanks for the reivew, I capitalized all Cassandra occurrences in new comments

@kingakowalska1
Copy link
Contributor

Hi,

Could we please tweak the message a bit? My suggestion is as follows:

If required, provide the type of Cassandra truststore and keystore that you used to hold keys and certificates for client encryption. Available store types are JKS and PKCS12. Default is JKS.

Also, in terratest/src/test/pega/data/values_zdt_upgrade_http_non_default_port81.yaml, we should include both available types as well. I would suggest using the same message as in all the other files.

Thanks!
Kinga

@wonim2022
Copy link
Contributor Author

Tweaked the message like you proposed @kingakowalska1

taz-pega-work
taz-pega-work approved these changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@taz-pega-work taz-pega-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look great. thanks for collaborating!

kingakowalska1
kingakowalska1 approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@kingakowalska1 kingakowalska1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@wonim2022 wonim2022 force-pushed the bugfix/BUG-868079-cassandra-store-type branch from 1d686a4 to 1e4187c Compare July 10, 2024 12:51
@wonim2022 wonim2022 force-pushed the bugfix/BUG-868079-cassandra-store-type branch from 1e4187c to 5cb52b4 Compare July 22, 2024 08:45
@taz-pega-work taz-pega-work merged commit 9abaf04 into pegasystems:master Jul 22, 2024
6 checks passed
@taz-pega-work
Copy link
Contributor

completing this bug fix by merging the fix at the request of Paul Bayliss

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kingakowalska1 kingakowalska1 kingakowalska1 approved these changes

@baylp2022 baylp2022 baylp2022 approved these changes

@taz-pega-work taz-pega-work taz-pega-work approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wonim2022 @kingakowalska1 @taz-pega-work @baylp2022