-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enabling secrets for ES certs and credentials #696
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Divyansh,
For the comments in the values.yaml file, please make the following changes:
Lines 64-66:
To specify a certificate using a secret, uncomment the esCertsSecret parameter and provide the secret name containing your certificate and certificate password (if any).
Use the full name of the certificate file (together with file extension, for example, “certificate.p12” or “certificate.jks”) as a key name in the secret. Use this key name to configure the “certificateName” parameter.
Use a key name “password” to provide the certificate password in the secret.
Lines 77-78:
To use a secret to configure basic authentication or TLS-based authentication between your external Elasticsearch service and SRS,
uncomment the esCredentialsSecret parameter and set it to the secret name. Use "username" and "password" as keys for your secret.
Thanks!
Thanks @kingakowalska1 for your comments, I've addressed them in the recent commit. Please check. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed new values configuration: CertsSecret & AuthSecret. Looks good !
4427b46
to
eaf29f6
Compare
Enabling secrets for ES certs and credentials