Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling secrets for ES certs and credentials #696

Merged
merged 5 commits into from
Feb 6, 2024

Conversation

bhowd1
Copy link
Contributor

@bhowd1 bhowd1 commented Feb 1, 2024

Enabling secrets for ES certs and credentials

@bhowd1 bhowd1 requested a review from a team February 1, 2024 11:58
@bhowd1 bhowd1 requested a review from a team as a code owner February 1, 2024 11:58
Copy link
Contributor

@kingakowalska1 kingakowalska1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Divyansh,

For the comments in the values.yaml file, please make the following changes:

Lines 64-66:

To specify a certificate using a secret, uncomment the esCertsSecret parameter and provide the secret name containing your certificate and certificate password (if any).
Use the full name of the certificate file (together with file extension, for example, “certificate.p12” or “certificate.jks”) as a key name in the secret. Use this key name to configure the “certificateName” parameter.
Use a key name “password” to provide the certificate password in the secret.

Lines 77-78:

To use a secret to configure basic authentication or TLS-based authentication between your external Elasticsearch service and SRS,
uncomment the esCredentialsSecret parameter and set it to the secret name. Use "username" and "password" as keys for your secret.

Thanks!

@bhowd1
Copy link
Contributor Author

bhowd1 commented Feb 2, 2024

Thanks @kingakowalska1 for your comments, I've addressed them in the recent commit. Please check.

Copy link
Contributor

@kingakowalska1 kingakowalska1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks!

charts/backingservices/values.yaml Outdated Show resolved Hide resolved
charts/backingservices/values.yaml Outdated Show resolved Hide resolved
Copy link

@ravitejamekapega ravitejamekapega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed new values configuration: CertsSecret & AuthSecret. Looks good !

@bhowd1 bhowd1 force-pushed the feature/US-590286 branch from 4427b46 to eaf29f6 Compare February 6, 2024 09:08
@bhowd1 bhowd1 merged commit 36e377b into pegasystems:master Feb 6, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants