Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

US-425386 Allow custom volume mounts and side car containers for installer #343

Merged
merged 36 commits into from
Oct 7, 2021
Merged

US-425386 Allow custom volume mounts and side car containers for installer #343

merged 36 commits into from
Oct 7, 2021

Conversation

MadhuriArugula
Copy link
Collaborator

@MadhuriArugula MadhuriArugula commented Sep 22, 2021 •
edited
Loading

Ability to inject custom side car containers and volume mounts to installer.

arugm and others added 16 commits October 8, 2020 14:10
Added Jenkinsfile
a6ffc48
Merging with master
acc61cb
@MadhuriArugula
Merge pull request #9 from pegasystems/master
67bd375 
Merging with master
@MadhuriArugula
Merge pull request #10 from pegasystems/master
9eb1e72 
Merging with master
@MadhuriArugula
Merge pull request #11 from pegasystems/master
9daaef1 
Merging with master
@MadhuriArugula
Merge pull request #12 from pegasystems/master
ab260e1 
Merging with master
US-415270 Migrate automation repo from bintray to test GitHub Pages
ca5ab7b
Validate artefact push against testing repo
a62832f
Validate artefact push against testing repo
c6c89da
@MadhuriArugula
Merge pull request #13 from MadhuriArugula/automationUpdate
ba9a36f 
Update to jenkins file to validate build tests
@MadhuriArugula
Update Jenkinsfile
0f56e15
@MadhuriArugula
Update Jenkinsfile
0326df8
@MadhuriArugula
Merge pull request #17 from pegasystems/master
3fe931a 
Merge with master
@MadhuriArugula
Merge branch 'pegasystems:master' into master
b731701
US-425386 Allow custom volume mounts and side car containers for inst…
6a4d8ec 
…aller
US-425386 Allow custom volume mounts and side car containers for inst…
60a14ff 
…aller
@MadhuriArugula MadhuriArugula requested review from dcasavant and a team as code owners September 22, 2021 13:58
@MadhuriArugula MadhuriArugula added the configs Label that generates configurations in automation repository label Sep 22, 2021
@pegaautomationuser
Copy link
Collaborator

Starting PR-343 validation on -> configs

2 similar comments
@pegaautomationuser
Copy link
Collaborator

Starting PR-343 validation on -> configs

@pegaautomationuser
Copy link
Collaborator

Starting PR-343 validation on -> configs

@pegaautomationuser
Copy link
Collaborator

Starting PR-343 validation on -> configs

@pegaautomationuser
Copy link
Collaborator

Starting PR-343 validation on -> configs

@pegaautomationuser
Copy link
Collaborator

Starting PR-343 validation on -> configs

@pegaautomationuser
Copy link
Collaborator

Starting PR-343 validation on -> configs

@pegaautomationuser
Copy link
Collaborator

Starting PR-343 validation on -> configs

@pegaautomationuser
Copy link
Collaborator

Starting PR-343 validation on -> configs

@pegaautomationuser
Copy link
Collaborator

Starting PR-343 validation on -> configs

@pegaautomationuser
Copy link
Collaborator

Starting PR-343 validation on -> configs

@pegaautomationuser
Copy link
Collaborator

Starting PR-343 validation on -> configs

@pegaautomationuser
Copy link
Collaborator

Starting PR-343 validation on -> configs

1 similar comment
@pegaautomationuser
Copy link
Collaborator

Starting PR-343 validation on -> configs

@pegaautomationuser
Copy link
Collaborator

Starting PR-343 validation on -> configs

@MadhuriArugula MadhuriArugula added integ-eks Label that triggers automation testing against EKS and removed configs Label that generates configurations in automation repository labels Oct 6, 2021
@pegaautomationuser
Copy link
Collaborator

Starting PR-343 validation on -> integ-eks

Saurabh-16
Saurabh-16 reviewed Oct 7, 2021
View reviewed changes
charts/pega/charts/installer/templates/_pega-installer-job.tpl
volumes:
{{- if and .root.Values.distributionKitVolumeClaimName (not .root.Values.distributionKitURL) }}
- name: {{ template "pegaDistributionKitVolume" }}
persistentVolumeClaim:
claimName: {{ .root.Values.distributionKitVolumeClaimName }}
{{- end }}
{{- end }}
{{- if .root.Values.custom }}{{- if .root.Values.custom.volumes }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this two if clubbed into one with AND operator?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Saurabh-16 Addressed as part of latest commit

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update: looks like and operator doesn't work because providing volumes under custom is optional. Having and operator in helm for such scenarios results in nil pointer exceptions

@pegaautomationuser
Copy link
Collaborator

Starting PR-343 validation on -> integ-eks

@MadhuriArugula MadhuriArugula removed the integ-eks Label that triggers automation testing against EKS label Oct 7, 2021
@shashikant-koder shashikant-koder self-requested a review October 7, 2021 11:49
@MadhuriArugula MadhuriArugula merged commit c77537b into pegasystems:master Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shashikant-koder shashikant-koder shashikant-koder approved these changes

@Saurabh-16 Saurabh-16 Saurabh-16 approved these changes

@dcasavant dcasavant Awaiting requested review from dcasavant

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MadhuriArugula @pegaautomationuser @Saurabh-16 @shashikant-koder