US-436846: BackingServices>Elasticsearch cluster-Encrypt internode communication enabled #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added init container in backingservices SRS deployment to wait for Internal ES Cluster
Anand-Kotamsetti
requested review from
dcasavant,
taz-pega-work and
a team
as code owners
Anand-Kotamsetti
requested review from
pega-kshev,
MadhuriArugula,
taz-mon and
a team
There was a problem hiding this comment.
Thanks for making the changes @Anand-Kotamsetti . I have minor edits that will help clarify a few things.
taz-pega-work
approved these changes
Sep 20, 2021
taz-pega-work
approved these changes
Sep 21, 2021
There was a problem hiding this comment.
Almost there. These look good!!
I made minor suggestions to address proper grammar and punctuation. Also, I thought the command to use with makefile is $ make es-prerequisite, so I added that comment in many of the review comments. if it really is $ es-prerequisite then please ignore that comment throughout.
taz-pega-work
approved these changes
Sep 22, 2021
taz-pega-work
approved these changes
Sep 22, 2021
There was a problem hiding this comment.
seems fine now...thanks for your time and patience @Anand-Kotamsetti !!
taz-pega-work
approved these changes
Sep 23, 2021
pega-kshev
reviewed
Sep 27, 2021
taz-pega-work
approved these changes
Sep 30, 2021
There was a problem hiding this comment.
looks good from a content and formatting perspective! ;-)
Nice work @Anand-Kotamsetti !
pega-kshev
approved these changes
Oct 1, 2021
MadhuriArugula
approved these changes
Oct 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1)Elasticsearch cluster-Encrypt inter node communication enabled in backingservices chart.
2)Added initContainer in SRS deployment to wait for internal elasticsearch to get ready.
3)Changes related to
US-436985 Update runbooks and readme for SRS.