Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial commit #1

Merged
merged 1 commit into from
Apr 18, 2019
Merged

initial commit #1

merged 1 commit into from
Apr 18, 2019

Conversation

dcasavant
Copy link
Member

Initial commit of 8.2.1 Helm Charts.

@dcasavant dcasavant requested review from cdancy and petehayes April 18, 2019 15:46
@dcasavant dcasavant self-assigned this Apr 18, 2019
Copy link

@cdancy cdancy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. At some point we'd probably want CI/CD to publish our helm chart to the official repos.

@cdancy cdancy added the enhancement New feature or request label Apr 18, 2019
@cdancy
Copy link

cdancy commented Apr 18, 2019

We might want to rename this project to align more with what the broader community is doing. Looking at other projects, and think towards the future, we might want to rename this project to just charts and then layer this a directory or 2 deep. This would allow us a single place to store other charts that we may want to create in the future. Take a look at the below projects to get an idea of what I'm thinking about.

https://github.com/helm/charts
https://github.com/bitnami/charts

@dcasavant
Copy link
Member Author

@cdancy Both of those examples include a number of charts - and we only have one for the time being. I was looking more to application examples than chart libraries (but I am flexible!).

I was also thinking that this repo would also hold the 'example yaml' files generated from these Helm charts. I don't see that as a common pattern in other repos but it seems to have been well received so far by those who have had early access. Maybe using a release is a better mechanism for that.

@cdancy
Copy link

cdancy commented Apr 18, 2019

hmmm ... if the templates were well received than I wonder if it makes more sense to just port the entire build process over to github to allow folks to generate those templates themselves?

Or, and within the build process in mind, once we do a release we could absolutely wrap up the templates and publish them somewhere.

@dcasavant dcasavant merged commit 0a19204 into pegasystems:master Apr 18, 2019
hsomu pushed a commit to hsomu/pega-helm-charts that referenced this pull request Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants