-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
US-620855 Add detemplatize executable using multi stage docker build #217
Conversation
@akshithac-21 With this change, we should be good to update this readme https://github.com/pegasystems/docker-pega-web-ready/blob/master/docs/Building-Image-With-Own-OS-And-JDK.md to remove the instructions to copy the detemplatize executable. |
Hi, I think we can safely combine lines 11 and 13 and shorten the first step to:
The rest looks great! Thanks, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Using detemplatize image as multi stage docker build, to avoid writing custom code to copy detemplatize library for building images with different OS and JDK.