[ISSUE-244] Fixed error with existing files in pulled screenshot folder #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ar and compose tests
mariuszmarzec
commented
Dec 20, 2021
| @@ -41,9 +37,7 @@ class Shot( | |||
|
|
|||
| def recordScreenshots( | |||
| appId: AppId, | |||
| shotFolder: ShotFolder, | |||
| projectName: String | |||
There was a problem hiding this comment.
Removed due tu unnecessary
mariuszmarzec
commented
Dec 20, 2021
| FileUtils.deleteDirectory(projectTemporalScreenshots) | ||
| } | ||
| FileUtils.deleteDirectory(new File(shotFolder.pulledScreenshotsFolder())) | ||
| FileUtils.deleteDirectory(new File(shotFolder.pulledComposeScreenshotsFolder())) |
There was a problem hiding this comment.
deleteDirectory method is checking if dir exists under the hood
mariuszmarzec
commented
Dec 20, 2021
| @@ -7,25 +7,26 @@ case class ShotFolder( | |||
| private val buildFolderPath: FilePath, | |||
| private val buildType: String, | |||
| private val flavor: Option[String], | |||
| private val directorySuffix: Option[String] | |||
| private val directorySuffix: Option[String], | |||
| private val separator: String | |||
There was a problem hiding this comment.
Adding separator in ShotFolder is necessary due to in moveComposeScreenshotsToRegularScreenshotsFolder 145 line there is replace fragment of file's path. It didn't work on Windows according to different slash.
pedrovgs
approved these changes
Dec 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 References
org.apache.commons.io.FileExistsException#244🎩 What is the goal?
Fixing error with existing files in pulled screenshot folder for regular and compose tests.
How is it being implemented?
pulledScreenshotFolderbefore downloading screenshotspulledScreenshotFolderShotFolderclassHow can it be tested?
gradlew testgradlew publishToMavenLocalgradlew executeScreenshot -Precordgradlew executeScreenshot