Change diagnostic message #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peczenyj
added a commit
that referenced
this pull request
Jun 5, 2024
* Bump codecov/codecov-action from 4.0.1 to 4.4.1 Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 4.0.1 to 4.4.1. - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md) - [Commits](codecov/codecov-action@v4.0.1...v4.4.1) --- updated-dependencies: - dependency-name: codecov/codecov-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Bump golang.org/x/tools in the production-dependencies group Bumps the production-dependencies group with 1 update: [golang.org/x/tools](https://github.com/golang/tools). Updates `golang.org/x/tools` from 0.21.0 to 0.22.0 - [Release notes](https://github.com/golang/tools/releases) - [Commits](golang/tools@v0.21.0...v0.22.0) --- updated-dependencies: - dependency-name: golang.org/x/tools dependency-type: direct:production update-type: version-update:semver-minor dependency-group: production-dependencies ... Signed-off-by: dependabot[bot] <support@github.com> * refactor * add doc * must support golang for-loop statements * change the danalyzer report message (#9) change from "can be replaced" by "should be replaced" --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
peczenyj
added a commit
that referenced
this pull request
Jun 5, 2024
…#10) * Bump codecov/codecov-action from 4.0.1 to 4.4.1 Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 4.0.1 to 4.4.1. - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md) - [Commits](codecov/codecov-action@v4.0.1...v4.4.1) --- updated-dependencies: - dependency-name: codecov/codecov-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Bump golang.org/x/tools in the production-dependencies group Bumps the production-dependencies group with 1 update: [golang.org/x/tools](https://github.com/golang/tools). Updates `golang.org/x/tools` from 0.21.0 to 0.22.0 - [Release notes](https://github.com/golang/tools/releases) - [Commits](golang/tools@v0.21.0...v0.22.0) --- updated-dependencies: - dependency-name: golang.org/x/tools dependency-type: direct:production update-type: version-update:semver-minor dependency-group: production-dependencies ... Signed-off-by: dependabot[bot] <support@github.com> * refactor * add doc * must support golang for-loop statements * change the danalyzer report message (#9) change from "can be replaced" by "should be replaced" --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
peczenyj
added a commit
that referenced
this pull request
Jun 5, 2024
* Bump codecov/codecov-action from 4.0.1 to 4.4.1 Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 4.0.1 to 4.4.1. - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md) - [Commits](codecov/codecov-action@v4.0.1...v4.4.1) --- updated-dependencies: - dependency-name: codecov/codecov-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Bump golang.org/x/tools in the production-dependencies group Bumps the production-dependencies group with 1 update: [golang.org/x/tools](https://github.com/golang/tools). Updates `golang.org/x/tools` from 0.21.0 to 0.22.0 - [Release notes](https://github.com/golang/tools/releases) - [Commits](golang/tools@v0.21.0...v0.22.0) --- updated-dependencies: - dependency-name: golang.org/x/tools dependency-type: direct:production update-type: version-update:semver-minor dependency-group: production-dependencies ... Signed-off-by: dependabot[bot] <support@github.com> * refactor * add doc * must support golang for-loop statements * change the danalyzer report message (#9) change from "can be replaced" by "should be replaced" * must support defer statement (#11) * must support defer statement * add test with t.Cleanup --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on this suggestion from @Antonboom
golangci/golangci-lint#4794 (comment)
instead:
we will: