Errors raised in DB_storage::toString() if there are multi-column keys, on PHP >= 7 #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s, on PHP >= 7
As reported by PHPCompatibility:
```
FILE: ./DB/storage.php
-----------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------
254 | ERROR | Indirect access to variables, properties and methods will be
| | evaluated strictly in left-to-right order since PHP 7.0. Use
| | curly braces to remove ambiguity.
-----------------------------------------------------------------------------
```
On PHP 5 this code correctly retrieves the class property whose name is held in `$keyname[$i]`.
As of PHP 7 it raises a number of PHP errors. They are notices on PHP 7 and warnings on PHP 8:
```
Warning: Array to string conversion in DB/storage.php on line 254
Warning: Undefined property: DB_storage::$Array in DB/storage.php on line 254
Warning: Trying to access array offset on null in DB/storage.php on line 254
```
Adding explicit braces resolves this issue and restores the intended behaviour across all PHP versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported by PHPCompatibility:
On PHP 5 this code correctly retrieves the class property whose name is held in
$keyname[$i].As of PHP 7 it raises a number of PHP errors. They are notices on PHP 7 and warnings on PHP 8:
Adding explicit braces resolves this issue and restores the intended behaviour across all PHP versions.