Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fetch remote before testing whether the publish branch exists #7

Merged
merged 11 commits into from
Sep 2, 2019
Merged

Fetch remote before testing whether the publish branch exists #7

merged 11 commits into from
Sep 2, 2019

Conversation

MikaelSmith
Copy link
Contributor

This re-uses the existing branch rather than always overwriting it with a new branch with single commit.

Signed-off-by: Michael Smith michael.smith@puppet.com

@MikaelSmith
Fetch remote before testing whether the publish branch exists
766f94d 
This re-uses the existing branch rather than always overwriting it with
a new branch with single commit.

Signed-off-by: Michael Smith <michael.smith@puppet.com>
@MikaelSmith
Copy link
Contributor Author

This might work, but I haven't tried. I ended up abandoning this approach because doing https://gohugo.io/hosting-and-deployment/hosting-on-github/ as a couple run steps turned out to be easier.

@peaceiris
enhance: change base docker image (ubuntu:18.04), use Bash, fix path
2b39ba3 
test: path

test: path

test: path

test: path

test: path

test: path

test: path

test: path

test: path

test: path

test: path

test: path
@peaceiris
Copy link
Owner

peaceiris commented Aug 24, 2019 •
edited
Loading

@MikaelSmith
Thank you for submitting your Pull Request. Your suggestion sounds good to me. After some testing, I will merge this and release as v2.0.0

@peaceiris
Copy link
Owner

@MikaelSmith You can test this pr with uses: MikaelSmith/actions-gh-pages@fix-branching

@jakubadamw
Copy link

I tried this out myself by swapping in the uses and it failed because there were no changes to be pushed to the branch¹. I think the action should use git commit --allow-empty.

¹ https://github.com/jakubadamw/blog/runs/203154661

@peaceiris
Copy link
Owner

@jakubadamw
Thanks for testing! I added --allow-empty. Test it again.

@jakubadamw
Copy link

@peaceiris, thanks, it works fine now! :)

floehopper added a commit to floehopper/jamesmead.org that referenced this pull request Sep 1, 2019
@floehopper
Avoid overwriting single commit on gh-pages branch
bc45c30 
See peaceiris/actions-gh-pages#7.
@peaceiris
Copy link
Owner

peaceiris commented Sep 2, 2019 •
edited
Loading

Thank you, everyone! I will release this change as v2.0.0 #10

@peaceiris peaceiris merged commit 76d9ea1 into peaceiris:master Sep 2, 2019
@peaceiris peaceiris mentioned this pull request Sep 2, 2019
Closed
@peaceiris
Copy link
Owner

v2.0.0 is released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MikaelSmith @peaceiris @jakubadamw