Skip to content

Commit

Permalink
Undo artefact renaming. It is broken. Instead accept that android/jvm…
Browse files Browse the repository at this point in the history
… serialization requires additional artefacts.
  • Loading branch information
pdvrieze committed Jun 13, 2024
1 parent 8e82608 commit 5216065
Show file tree
Hide file tree
Showing 62 changed files with 3,123 additions and 42 deletions.
1,469 changes: 1,469 additions & 0 deletions core/base/api/core.api

Large diffs are not rendered by default.

1,648 changes: 1,648 additions & 0 deletions core/base/api/core.klib.api

Large diffs are not rendered by default.

24 changes: 3 additions & 21 deletions core/base/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -50,26 +50,20 @@ kotlin {
applyDefaultXmlUtilHierarchyTemplate()
explicitApi()

components.configureEach {
val c: SoftwareComponent = this

logger.lifecycle("Found component ${c.name}")
}

val testTask = tasks.create("test") {
group = "verification"
}
val cleanTestTask = tasks.create("cleanTest") {
group = "verification"
}

jvm {
jvm("jvmCommon") {
compilations.all {
tasks.named<Test>("${target.name}Test") {
testTask.dependsOn(this)
}
cleanTestTask.dependsOn(tasks.getByName("clean${target.name[0].uppercaseChar()}${target.name.substring(1)}Test"))
tasks.named<Jar>("jvmJar") {
tasks.named<Jar>("jvmCommonJar") {
manifest {
attributes("Automatic-Module-Name" to autoModuleName)
}
Expand Down Expand Up @@ -116,12 +110,6 @@ kotlin {
}

targets.all {
val targetName = name
mavenPublication {
when (targetName) {
"jvm" -> artifactId = "core-jvmCommon"
}
}
@Suppress("OPT_IN_USAGE")
when (val t = this) {
is HasConfigurableKotlinCompilerOptions<*> -> t.compilerOptions {
Expand All @@ -146,7 +134,7 @@ kotlin {
}
}

val jvmTest by getting {
val jvmCommonTest by getting {
dependencies {
implementation(kotlin("test-junit5"))
implementation(libs.junit5.api)
Expand All @@ -165,12 +153,6 @@ kotlin {

}

publishing {
publications.withType<MavenPublication>().named("kotlinMultiplatform") {
artifactId = "core-base"
}
}

addNativeTargets()

apiValidation {
Expand Down
File renamed without changes.
22 changes: 2 additions & 20 deletions core/compat/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -39,16 +39,8 @@ kotlin {
explicitApi()
applyDefaultXmlUtilHierarchyTemplate()

jvm("jdk") {
mavenPublication {
artifactId = "core-compat-jdk"
}
}
jvm("android") {
mavenPublication {
artifactId = "core-compat-android"
}
}
jvm("jdk")
jvm("android")
js {
browser()
}
Expand Down Expand Up @@ -85,14 +77,4 @@ kotlin {

addNativeTargets()

publishing {
publications.withType<MavenPublication>().named("kotlinMultiplatform") {
artifactId = "core"
components.named("kotlin") {
val c: ComponentWithVariants = this as ComponentWithVariants
logger.lifecycle("Found component \"kotlin\" with variants")
}
}
}

doPublish("compat")
2 changes: 1 addition & 1 deletion gradle/libs.versions.toml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ kotlin = "2.0.0"
kotlinx-serialization = "1.7.0-RC"
kxml2 = "2.3.0"
woodstox = "6.6.2"
xmlutil = "0.90.0-RC3-SNAPSHOT"
xmlutil = "0.90.0-RC4-SNAPSHOT"

[libraries]
woodstox = { module = "com.fasterxml.woodstox:woodstox-core", version.ref = "woodstox" }
Expand Down

0 comments on commit 5216065

Please sign in to comment.