-
-
Notifications
You must be signed in to change notification settings - Fork 424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: add minimum
save strategy
#752
Conversation
This strategy uses lower-bounds for version constraints. This is useful for calver, where the upper-bound no longer explicity defines API compatibility.
Co-authored-by: Timothée Mazzucotelli <pawamoy@pm.me>
I just want to take the time to say how cool this project is. It's really easy to navigate the source code, and I like the fact that the scope of I was looking for something a bit more customiseable than poetry, and uses PEP 621, and |
Codecov Report
@@ Coverage Diff @@
## main #752 +/- ##
=======================================
Coverage 83.77% 83.77%
=======================================
Files 73 73
Lines 6143 6146 +3
Branches 1094 1095 +1
=======================================
+ Hits 5146 5149 +3
Misses 705 705
Partials 292 292
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@agoose77 Welcome to PDM! Care to update the completion scripts under |
Darn, I thought I'd caught everything! Will do. |
@frostming I've updated the completions, and modified the completions script to support ZSH and powershell. Was this a deliberate omission, or am I OK to keep the fix in this PR? I can't test the PS1 changes without a Windows machine, and it seems like a big diff. |
oh, just keep them and add a single option manually |
OK, will revert the change. Out of interest, why do we not use the completions generator for powershell/zsh? I noticed some spelling errors in the hand-crafted ones. |
cb98569
to
f24c420
Compare
because they are hand written, for some value completion. no autocomplete engine can generate such customized contents. |
Right, makes sense. I think this PR is done from my end, are there any outstanding change to be made? :) |
LGTM, thanks for fixing all the typos |
Pull Request Check List
news/
describing what is new.Describe what you have changed in this PR.
This PR adds
--save-minimum
topdm add
for cases where the user doesn't want an upper bound (e.g. non SemVer uses)See also