Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed zsh completion for pep582 flag #1218

Merged

Conversation

SuperfastTimeTraveler
Copy link
Contributor

Pull Request Check List

  • A news fragment is added in news/ describing what is new.
  • Test cases added for changed code.

Fixed the invalid option definition in the pdm zsh completion for the --pep582 flag.

The exact error was _arguments:comparguments:327: invalid option definition: --pep582=[Print the command line to be eval by the shell]:shell:(zsh bash fish tcsh csh).

Images:

The problem:
faulty

The fix:
corrected

@codecov-commenter
Copy link

codecov-commenter commented Jul 11, 2022

Codecov Report

Merging #1218 (9751c1a) into main (129cd97) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1218   +/-   ##
=======================================
  Coverage   81.10%   81.10%           
=======================================
  Files          93       93           
  Lines        7622     7622           
  Branches     1772     1796   +24     
=======================================
  Hits         6182     6182           
  Misses       1085     1085           
  Partials      355      355           
Flag Coverage Δ
unittests 80.98% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9decf9f...9751c1a. Read the comment docs.

@frostming frostming merged commit b06b44e into pdm-project:main Jul 12, 2022
@SuperfastTimeTraveler SuperfastTimeTraveler deleted the correct-zsh-completion branch July 12, 2022 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants