Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for truststore package #2049

Closed
p-rogalski opened this issue Jun 23, 2023 · 0 comments · Fixed by #2055
Closed

Add support for truststore package #2049

p-rogalski opened this issue Jun 23, 2023 · 0 comments · Fixed by #2055
Assignees
Labels
⭐ enhancement Improvements for existing features

Comments

@p-rogalski
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Currently, pdm uses certifi to validate SSL certificates. A custom CA bundle can be passed with pypi.ca_certs for validation of self-signed certificates.

This does not work well on Windows, because the CA bundle is not stored in the filesystem, but in the windows certificate store.

Describe the solution you'd like

Add support for the truststore package, which injects the certificates from the system certificate store into the standard library ssl module.

Pip already added experimental support of truststore behind a feature flag.

Only downside: truststore requires at least Python 3.10, but i guess this could be handled with a simple version check.

@p-rogalski p-rogalski added the ⭐ enhancement Improvements for existing features label Jun 23, 2023
@frostming frostming self-assigned this Jun 26, 2023
frostming added a commit that referenced this issue Jun 26, 2023
Fixes #2049

Signed-off-by: Frost Ming <me@frostming.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⭐ enhancement Improvements for existing features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants