Skip to content

Commit

Permalink
fix precedence in portstat CLI (sonic-net#2874)
Browse files Browse the repository at this point in the history
  • Loading branch information
wenyiz2021 authored and pdhruv-marvell committed Aug 23, 2023
1 parent 26c24ec commit 5812025
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
4 changes: 2 additions & 2 deletions scripts/portstat
Original file line number Diff line number Diff line change
Expand Up @@ -338,7 +338,7 @@ class Portstat(object):
print(table_as_json(table, header))
else:
print(tabulate(table, header, tablefmt='simple', stralign='right'))
if multi_asic.is_multi_asic() or device_info.is_chassis() and not use_json:
if (multi_asic.is_multi_asic() or device_info.is_chassis()) and not use_json:
print("\nReminder: Please execute 'show interface counters -d all' to include internal links\n")

def cnstat_intf_diff_print(self, cnstat_new_dict, cnstat_old_dict, intf_list):
Expand Down Expand Up @@ -556,7 +556,7 @@ class Portstat(object):
print(table_as_json(table, header))
else:
print(tabulate(table, header, tablefmt='simple', stralign='right'))
if multi_asic.is_multi_asic() or device_info.is_chassis() and not use_json:
if (multi_asic.is_multi_asic() or device_info.is_chassis()) and not use_json:
print("\nReminder: Please execute 'show interface counters -d all' to include internal links\n")

def main():
Expand Down
1 change: 0 additions & 1 deletion tests/portstat_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,6 @@
Reminder: Please execute 'show interface counters -d all' to include internal links
"""


intf_invalid_asic_error = """ValueError: Unknown Namespace asic99"""

intf_counters_detailed = """\
Expand Down

0 comments on commit 5812025

Please sign in to comment.