Always return a str from literal_name
#978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… literal. This fixes #977 because it makes the literal name object hashable. This sample PDF will now crash with a PDFSyntaxError. That's good.
pietermarsman
changed the title
str from literal_name even if the object is not a…str from literal_name
pietermarsman
deleted the
977-oss-fuzz-issue-70071-pdfminersixpage_extraction_fuzzer-uncaught-exception-in-do_keyword
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
This is what happened in practice for correct input (e.g.
PSLiteral). But now it also always returns astrwhen the object is not aPSLiteral.This fixes #977 because it makes the literal name object hashable. This sample PDF will now crash with a PDFSyntaxError. That's good.
How Has This Been Tested?
With the PDF from #977. And with nox.
Checklist