Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make FormatReader sync #98

Merged
merged 2 commits into from
Jan 29, 2022
Merged

Make FormatReader sync #98

merged 2 commits into from
Jan 29, 2022

Conversation

sagudev
Copy link
Contributor

@sagudev sagudev commented Jan 22, 2022

similar as #24 just for impl sync trait.

@sagudev
Copy link
Contributor Author

sagudev commented Jan 22, 2022

Had some problems with VSCode formatter which used stable formatter.

The only active nightly formating is control_brace_style = "ClosingNextLine". Is it really needed?

@sagudev
Copy link
Contributor Author

sagudev commented Jan 25, 2022

ping @pdeljanov

@pdeljanov
Copy link
Owner

Hi @sagudev,

I'm not 100% up-to-speed on Send/Sync, so I will need to read up and consider the implications of this change and if it'll impose any restrictions to developers. My initial thought is that it should be fine.

That being said, this would be a semver breaking change so I'll make sure to do that before version 0.5 which should be in a couple weeks.

@pdeljanov pdeljanov modified the milestones: v0.5.1, v0.5 Jan 27, 2022
@pdeljanov
Copy link
Owner

Hi @sagudev,

Thank you for your patience. I think this is a good idea and I see little obvious downside. Would you mind also adding Sync to the codecs::Decoder and meta::MetadataReader traits for consistency and so we can get all the changes in a single commit?

Thanks!

@sagudev
Copy link
Contributor Author

sagudev commented Jan 28, 2022

I added Sync to all traits that already implemented Send.

@pdeljanov pdeljanov merged commit 93727d4 into pdeljanov:master Jan 29, 2022
@pdeljanov
Copy link
Owner

Thank you @sagudev!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants