allow filebeat major_version 8 to be used

[rwaffen]

No description provided.

[pcfens]

Thanks for submitting this. Is there any special logic we need to handle version 8 beyond just allowing it as an option (different config file, removing an old version, etc.)?

[rwaffen]

as far as i tested it: no. i just took my 7 setup and installed filebeat 8.x and it worked. not sure if this is a "good" test.
only patched this one line and everything else worked out of the box.

[pcfens]

I'm glad I waited to merge this - do things look ok now? I know this is a potentially bigger change, and we're making less and less use of filebeat now so I don't have a great way to test in production.

[rwaffen]

yes sorry for the late changes. i had it first running, somehow. and than i deleted my whole setup and recreated everything from scratch and ran into some problems. but now it looks good. have testet it several times with version 8.

[rbos]

I was just working on an ELK setup (first time in a few years) and filebeat 8 changes how docker shipping configs work. Instead of type: docker it uses type: container and requires that you set a path.

[rwaffen]

oh okay, we don't do containers here so i never stumbled upon this … this feature exists since 7.2 and docker is deprecated. so we might change this too. i will have a look to include this in my change. 🤔

[rwaffen]

i had now time to look into this. It looks like we don't have to do anything here? If you set the input_type for the input to container it behaves like log . It than falls in the else tree of this if-block:

puppet-filebeat/templates/input.yml.erb

Lines 24 to 27 in f0fcf70

	<%- else -%>
	paths:
	<%- @paths.each do |log_path| -%>
	- <%= log_path %>

@rbos did you have to change something to make it work with version 8? except that the input_type now is named container instead of docker?

[fetzerms]

@pcfens is there any change to get this merged? Filebeat v8 has been out for a while and I'd love to keep using this module here :-)