Update facter script to work with hideously old filebeat #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems simple enough and doesn't add any real overhead to keeping the newer code up. I'll try to release a new version later today or tomorrow Thanks for submitting this and good luck with your old versions of filebeat. |
|
Thanks, with any luck I'll be making the old filebeat die in a fire soon! |
|
Sorry that took so long - I just released 4.1.1 to the forge. |
|
No worries, if you saw the timeframe of our ELK upgrade project, you wouldn't feel so bad about that release schedule. 😆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We unfortunately have some filebeat 1.x hanging around and if this module is applied it complains about
undefined method[]' for nil:NilClassbecause the really old filebeat usedfilebeat --versioninstead of the new fancyfilebeat version. I had modified our local version of the module to use that, but now that we're looking at 7.x that fix doesn't work as--version` is now an error. Saw the empty version handling for the Windows clients and thought the same could be applied to make the super old ugly busted filebeat 1.x stuff happy as well.Totally understand if supporting viciously outdated code is not worthy of a merge.