explicitly set service provider on redhat systems #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| case $::osfamily { | ||
| 'RedHat': { | ||
| $service_provider = 'redhat' | ||
| } |
There was a problem hiding this comment.
What happens if service_provider is set to redhat on versions < 7? Does everything still work?
There was a problem hiding this comment.
Yes it does. I had actually updated the original comment to add that. This is the default provider in < 7:
https://docs.puppetlabs.com/puppet/latest/reference/type.html#service-provider-redhat
pcfens
added a commit
that referenced
this pull request
Mar 21, 2016
explicitly set service provider on redhat systems
|
Thanks for catching this - I pushed this up to the forge in v0.5.8. |
|
Thanks for the quick turnaround! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
filebeat ships an init script, even on EL7 systems. puppet 4 cannot correctly check the status of init scripts through the EL7 systemd->init wrapper and thus attempts to start the service every time. While this doesn't actually try and start the service, the systemd wrapper is smart enough, it does cause an always changing scenario on every run.
Explicitly setting the provider to 'redhat' solves this and is safe even on older non-systemd redhat systems.