Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for FreeBSD #130

Merged
merged 13 commits into from
Dec 11, 2017
Merged

Add support for FreeBSD #130

merged 13 commits into from
Dec 11, 2017

Conversation

AlessandroLorenzi
Copy link
Contributor

Hallo,
I've added support for FreeBSD.

Referred to issue #129

@pcfens
Copy link
Owner

pcfens commented Aug 29, 2017

Thanks for sending this along - I don't use BSD at all, so I'll have to trust that this will work as expected.

Can you take a look at fixing some of the tests that are failing? Adding tests is also a big help if you're able- as more changes are made the module it's always helpful to know that nothing is being broken on accident.

Thanks again

@lesinigo
Copy link
Contributor

Seems like the failed tests are just cosmetic issues in code / yaml style, we should be able to fix them and push a fix soon

@lesinigo
Merge tag 'v2.3.0' into freebsd_2.3.0
ea88d89 
Version 2.3.0
- Add support for Filebeat 6
- Add Support for hash.random in Kafka output
@lesinigo
cleanup and cosmetic fixes
cd05ac9
@lesinigo
use default FreeBSD rcscript and config file path
99f9256
@lesinigo
Copy link
Contributor

I've made some general clean up so tests won't fail anymore and I also reverted to the FreeBSD-provided init script and config file path.

Sorry for this taking a long time... it should be fine now, we are actually using it on FreeBSD 11.1-RELEASE. Please take a look and tell us if there is anything else needed for a merge. thanks 👍

@pcfens pcfens merged commit 3e1ffba into pcfens:master Dec 11, 2017
@lesinigo lesinigo mentioned this pull request Dec 11, 2017
Closed
@pcfens pcfens mentioned this pull request Dec 21, 2017
Closed
@lesinigo lesinigo deleted the freebsd branch April 10, 2018 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlessandroLorenzi @pcfens @lesinigo