Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BRAM unlock bit should be able to re-lock #111

Closed
dshadoff opened this issue Oct 15, 2022 · 3 comments
Closed

BRAM unlock bit should be able to re-lock #111

dshadoff opened this issue Oct 15, 2022 · 3 comments

Comments

@dshadoff
Copy link
Member

Backup memory unlock bit (0x1807 bit 7) is set to unlock BRAM (i.e. set 0x1807 = 0x80).
Normally, BRAM is re-locked by reading 0x1803, but can also be locked by resetting bit of 0x1807 (i.e. same as above but the bit is reset).

@dshadoff
Copy link
Member Author

Hmm... there appear to be no restrictions/locking on BRAM for HuCard games; only CDROM...

@dshadoff
Copy link
Member Author

dshadoff commented Nov 8, 2023

Notes:
The physical (and logical) memory will (or should) only show BRAM data if the BRAM is unlocked.
The "BRAM" page of memory editor shows the data regardless of lock.

The HuCard BRAM apparently doesn't implement locking.
The CDROM BRAM - while it implements locking and unlocking - was improperly locking the BRAM when the debugger screen was displayed, due to inappropriate behaviour when a "silent" read takes place for the purposes of refreshing the display.
This improper CDROM behaviour is being dealt with in issue #112 .

Neither of these systems was dealing with the "re-lock" data value on the lock bit.

dshadoff added a commit to dshadoff/mednafenPceDev that referenced this issue Nov 21, 2023
@dshadoff
Copy link
Member Author

Re-locking behaviour has had a Pull Request submitted.

The HuCard improper locking now has a new issue created against it (HuCard BRAM defaults to visible) - issue #136

pceDev16 added a commit that referenced this issue Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant