ENH: use AlarmCircle, if available #91
Conversation
| if TyphosAlarmCircle is not None: | ||
| def indicator_for_device(device): | ||
| """Create a QWidget to indicate the alarm state of a QWidget""" | ||
| circle = TyphosAlarmCircle() |
There was a problem hiding this comment.
The only other thing I was considering was seeing how it looked/performed with:
| circle = TyphosAlarmCircle() | |
| circle = TyphosAlarmCircle() | |
| circle.kindLevel = circle.KindLevel.NORMAL |
Hypotheses:
hinted, the default, might not catch all the issues with some devicesnormalmight slow down the load- the mouseover might get silly in some cases if there are too many signals included
But I'm really not sure
There was a problem hiding this comment.
I was surprised at just how fast it loaded the sample hutches I tried with normal, to be honest.
That said, I agree that hinted may be sufficient enough and will almost certainly lead to even faster loading. Perhaps we leave it as-is and try it out a bit more, falling back to hinted if necessary?
There was a problem hiding this comment.
I opened all the lucids with hinted and with normal, hinted seems more friendly to me (smaller tooltips) and normal didn't reveal any new erroring devices. So let's leave it as-is I think
|
This looks really good with the tooltip expansion you suggested in the typhos PR, it adds functionality to the grid where you can figure out which circle is which at all times |
|
Immediate karma on the ci updates- I'll push a fix |
|
There's a deprecation/removal in python 3.9 that causes an issue with networkx < 2.5, and we have this gem in the travis output: Rather than muck with the conda recipe or travis builds here to make it pass I'm just going to mark 3.9 as an allowed failure for now |
Description
I couldn't help but wonder how the new alarm functionality looked in typhos with pcdshub/typhos#441
The answer is that it looks great! See the following view of RIX from psbuild in the grid:
which is an accurate reflection of the alarm state:
is similarly correctly determined:And the tooltips are fantastic.
Context
Closes #86 (and steals a bit of Zach's thunder)
Supersedes #89
Notes
Back-compat with the previous implementation may be unnecessary. If you feel strongly one way or another, I'd happily modify this PR.
If we decide to remove backward-compatibility of typhos, I'll adjust the version pin once the relevant PR is in and typhos is tagged. Otherwise, LUCID can be tagged/released independently.