Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Refactor From-Parent-Directory Imports #194

Merged
merged 1 commit into from
Jan 13, 2024

Conversation

pcaversaccio
Copy link
Owner

@pcaversaccio pcaversaccio commented Jan 13, 2024

🕓 Changelog

This PR refactors all from-parent-directory imports (the previously used pattern is technically incorrect in Python and is no longer allowed in the latest version of the Vyper main branch):

- from ..dir.interfaces.IERCXXXX import IERCXXXX
+ from ..dir.interfaces import IERCXXXX

Furthermore, we also bump ethers and prettier to the latest (non-breaking) versions as well as we update all submodules to the latest available commits.

🐶 Cute Animal Picture

image

Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
@pcaversaccio pcaversaccio self-assigned this Jan 13, 2024
@pcaversaccio pcaversaccio added dependencies 🔁 Pull requests that update a dependency file refactor/cleanup ♻️ Code refactorings and cleanups labels Jan 13, 2024
@pcaversaccio pcaversaccio added this to the 0.0.5 milestone Jan 13, 2024
Copy link
Contributor

@charles-cooper charles-cooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can't approve, but lgtm!

@pcaversaccio pcaversaccio merged commit f716a5c into main Jan 13, 2024
11 checks passed
@pcaversaccio pcaversaccio deleted the refactor-parent-imports branch January 13, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies 🔁 Pull requests that update a dependency file refactor/cleanup ♻️ Code refactorings and cleanups
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants