Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix removing warning from production build #256

Merged
merged 1 commit into from
Nov 5, 2019
Merged

Fix removing warning from production build #256

merged 1 commit into from
Nov 5, 2019

Conversation

adam187
Copy link
Contributor

@adam187 adam187 commented Nov 1, 2019

The current solution is not really working since after webpack replacement we end up with:

if (process && process.env && (false || 'test')) {

whitch is alway true and this part of code is never removed from production build.

@pburtchaell pburtchaell merged commit 4118328 into pburtchaell:master Nov 5, 2019
@pburtchaell
Copy link
Owner

Thanks!

@pburtchaell
Copy link
Owner

Released to redux-promise-middleware@6.1.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adam187 @pburtchaell