Compatibility with Android Studio Meerkat | 2024.3.1 Canary 7 (2024.3.1.7) #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raghavsatyadev
commented
Dec 19, 2024
raghavsatyadev
commented
- Updated the IDE version to 2024.3.1.6. -> gradle.properties
- added JVM Args and Kotlin Code Style. -> gradle.properties
- Updated Gradle Wrapper to 8.12-rc-2. -> gradle-wrapper.properties
- Updated Java compatibility to version 21. -> build.gradle.kts
- Updated notification groups to use the NotificationGroupManager API. -> NotificationHelper.kt
- Removed deprecation in ReflectKt.kt
- Added Gradle Script file to run "buildPlugin runIde" commands directly without creating a configuration manually. -> BuildRun.run.xml
- Updated .gitignore to exclude .kotlin folder
- Updated the IDE version to 2024.3.1.6. -> gradle.properties - added JVM Args and Kotlin Code Style. -> gradle.properties - Updated Gradle Wrapper to 8.12-rc-2. -> gradle-wrapper.properties - Updated Java compatibility to version 21. -> build.gradle.kts - Updated notification groups to use the NotificationGroupManager API. -> NotificationHelper.kt - Removed deprecation in ReflectKt.kt - Added Gradle Script file to run "buildPlugin runIde" commands directly without creating a configuration manually. -> BuildRun.run.xml - Updated .gitignore to exclude .kotlin folder
raghavsatyadev
changed the title
pbreault
reviewed
Dec 19, 2024
src/main/kotlin/com/developerphil/adbidea/ui/NotificationHelper.kt
Outdated
Show resolved
Hide resolved
- analyzed the project and fixed some suggestions from the studio analyzer -> DeviceResultFetcher.kt, UseSameDevicesHelper.kt, Debugger.kt, MyDeviceChooser.kt, ObjectGraph.kt - Updated run configurations to removed buildPlugin and make 2 separate configurations for runIde and runLocalIde - gradle-wrapper.properties downgraded to 8.11.1 - Removed listener from NotificationHelper.kt - Updated Application.kt to use @service instead of Android Components API, removed <application-components> from -> plugin.xml - Added temporary logo - Updated org.jetbrains.kotlin.jvm to 2.1.0 - Updated org.jetbrains.changelog to 2.2.1 - replaced sourceCompatibility with jvmToolchain - Updated sinceBuild to 243.22562.145 -> gradle.properties
|
@pbreault Added the changes that you requested. Plus:
I also wanted to update org.jetbrains.intellij.platform but couldn't because of some missing plugin error Missing Plugin |
- updated gradle wrapper to 8.12 - readying the code for org.jetbrains.intellij.platform : 2.2.1
raghavsatyadev
changed the title
pbreault
requested changes
Dec 25, 2024
src/main/kotlin/com/developerphil/adbidea/adb/DeviceResultFetcher.kt
Outdated
Show resolved
Hide resolved
- removed plugin icon - removed commented code that was going to be used when upgrading org.jetbrains.intellij.platform to latest version
|
@pbreault changes done as requested |
|
@pbreault if you got time, can you please review this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.