💚 Normalize test env between Rubies

pboling · Sep 22, 2024 · fd21396 · fd21396
1 parent 4aeeaad
commit fd21396
Show file tree

Hide file tree

Showing 9 changed files with 12 additions and 25 deletions.
diff --git a/.rubocop_gradual.lock b/.rubocop_gradual.lock
@@ -1,5 +1,5 @@
 {
-  "spec/gem_bench/team_spec.rb:1266648289": [
+  "spec/gem_bench/team_spec.rb:544152244": [
     [39, 7, 21, "RSpec/MultipleExpectations: Example has too many expectations [2/1].", 4057686576],
     [39, 7, 463, "RSpec/ExampleLength: Example has too many lines. [12/5]", 717044346],
     [238, 9, 22, "RSpec/MultipleExpectations: Example has too many expectations [2/1].", 837383149],
@@ -17,7 +17,7 @@
     [362, 11, 20, "RSpec/MultipleExpectations: Example has too many expectations [2/1].", 608832949],
     [362, 11, 956, "RSpec/ExampleLength: Example has too many lines. [15/5]", 1208468539],
     [383, 13, 20, "RSpec/MultipleExpectations: Example has too many expectations [2/1].", 608832949],
-    [383, 13, 1083, "RSpec/ExampleLength: Example has too many lines. [16/5]", 3055949499],
-    [408, 9, 18, "RSpec/MultipleExpectations: Example has too many expectations [2/1].", 2487416927]
+    [383, 13, 931, "RSpec/ExampleLength: Example has too many lines. [14/5]", 581654106],
+    [406, 9, 18, "RSpec/MultipleExpectations: Example has too many expectations [2/1].", 2487416927]
   ]
 }
diff --git a/Gemfile b/Gemfile
@@ -10,8 +10,6 @@ gem <<~GEM_NAME.chomp
   pry-byebug
 GEM_NAME
 
-# Need faker be loaded by bundler for evaluation in specs
-gem "faker", "~> 3.4", ">= 3.4.2"
 # Need test-unit be loaded by bundler for evaluation in specs
 gem "test-unit", "~> 3.6"
 

diff --git a/Gemfile.lock b/Gemfile.lock
@@ -173,7 +173,7 @@ PLATFORMS
 DEPENDENCIES
   bundler
   byebug (>= 2.0.3)
-  faker (~> 3.4, >= 3.4.2)
+  faker (~> 3.4, = 3.4.2)
   gem_bench!
   kettle-soup-cover (~> 1.0, >= 1.0.2)
   method_source (>= 1.1.0)

diff --git a/gemfiles/ancient.gemfile b/gemfiles/ancient.gemfile
@@ -18,8 +18,6 @@ gem "rspec"
 gem "rspec-block_is_expected"
 gem "super_diff"
 
-# Need faker be loaded by bundler for evaluation in specs
-gem "faker", "~> 3.4", ">= 3.4.2"
 # Need test-unit be loaded by bundler for evaluation in specs
 gem "test-unit", "~> 3.6"
 

diff --git a/gemfiles/coverage.gemfile b/gemfiles/coverage.gemfile
@@ -8,7 +8,5 @@ source "https://rubygems.org"
 
 gemspec path: "../"
 
-# Need faker be loaded by bundler for evaluation in specs
-gem "faker", "~> 3.4", ">= 3.4.2"
 # Need test-unit be loaded by bundler for evaluation in specs
 gem "test-unit", "~> 3.6"
diff --git a/gemfiles/style.gemfile b/gemfiles/style.gemfile
@@ -8,7 +8,5 @@ source "https://rubygems.org"
 
 gemspec path: "../"
 
-# Need faker be loaded by bundler for evaluation in specs
-gem "faker", "~> 3.4", ">= 3.4.2"
 # Need test-unit be loaded by bundler for evaluation in specs
 gem "test-unit", "~> 3.6"
diff --git a/gemfiles/vanilla.gemfile b/gemfiles/vanilla.gemfile
@@ -8,7 +8,5 @@ source "https://rubygems.org"
 
 gemspec path: "../"
 
-# Need faker be loaded by bundler for evaluation in specs
-gem "faker", "~> 3.4", ">= 3.4.2"
 # Need test-unit be loaded by bundler for evaluation in specs
 gem "test-unit", "~> 3.6"
diff --git a/spec/gem_bench/scout_spec.rb b/spec/gem_bench/scout_spec.rb
@@ -165,7 +165,6 @@
             [
               "# For complexity!\n",
               "# (this syntax is not supported by gem_bench, but also shouldn't make it blow up)\n",
-              "# Need faker be loaded by bundler for evaluation in specs\n",
               "# Need test-unit be loaded by bundler for evaluation in specs\n",
               "# Specify your gem's dependencies in gem_bench.gemspec\n",
             ],
@@ -206,7 +205,6 @@
             [
               "# For complexity!\n",
               "# (this syntax is not supported by gem_bench, but also shouldn't make it blow up)\n",
-              "# Need faker be loaded by bundler for evaluation in specs\n",
               "# Need test-unit be loaded by bundler for evaluation in specs\n",
               "# Specify your gem's dependencies in gem_bench.gemspec\n",
             ],
@@ -230,7 +228,6 @@
           [
             "# For complexity!\n",
             "# (this syntax is not supported by gem_bench, but also shouldn't make it blow up)\n",
-            "# Need faker be loaded by bundler for evaluation in specs\n",
             "# Need test-unit be loaded by bundler for evaluation in specs\n",
             "# Specify your gem's dependencies in gem_bench.gemspec\n",
           ],

diff --git a/spec/gem_bench/team_spec.rb b/spec/gem_bench/team_spec.rb
@@ -384,15 +384,15 @@
               allow(scout).to receive(:loaded_gems).and_return([["rspec", "3.13.0"]])
               allow(GemBench::Scout).to receive(:new).and_return(scout)
               out1 = <<~OUT1.chomp
-                       [GemBench] Will show bad ideas.  Be Careful.
-                       [GemBench] Detected 1 loaded gems
-                       [GemBench] Found no gems that need to load at boot time.
-                     OUT1
+                [GemBench] Will show bad ideas.  Be Careful.
+                [GemBench] Detected 1 loaded gems
+                [GemBench] Found no gems that need to load at boot time.
+              OUT1
               out2 = <<~OUT2.chomp
-                       [GemBench] Here are 1 suggestions for improvement:
-                       \t[SUGGESTION] 1) rspec had no files to evaluate.
-                       [GemBench] Evaluated 1 gems against your Gemfile but found no primary dependencies which can safely skip require on boot (require: false).
-                     OUT2
+                [GemBench] Here are 1 suggestions for improvement:
+                \t[SUGGESTION] 1) rspec had no files to evaluate.
+                [GemBench] Evaluated 1 gems against your Gemfile but found no primary dependencies which can safely skip require on boot (require: false).
+              OUT2
               block_is_expected.to not_raise_error.and output(include(out1, out2)).to_stdout
               expect(GemBench::Scout).to have_received(:new)
             end