This repository was archived by the owner on Nov 15, 2020. It is now read-only.
Moved away from jQuery cookie towards js-cookie #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o longer supported and will eventually lead to developers using two cookie solutions in their code bases.
|
👍 I will compare this to the other fork and merge one shortly. They look nearly identical from a cursory overview. |
|
@JakeTheSnake3p0 please rebase on master, fix the conflicts, and I will merge this. On the changelog conflict, the move to js.cookie needs to be at least a minor version bump, as we are trying to follow semver 2.0. |
|
Not sure if I "rebased" correctly. All the older commits since #e6b9eda still show up in my commit history, but all the files are up to date. |
|
It's fine, thanks! |
pboling
reviewed
Feb 9, 2017
| @@ -1,3 +1,7 @@ | |||
| ### 0.3.6 - FEB.06.2017 | |||
There was a problem hiding this comment.
This is still wrong, but I can fix it before I release it. Needs to be a minor version bump, not a patch level version bump. MAJOR.MINOR.PATCH ;)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jQuery cookie is no longer being supported. At some point devs will move on to using js-cookie for other reasons and it doesn't make sense to have two js cookie solutions in their projects. I haven't done testing on Rails 2 but I can't imagine these changes have done anything to break it. I've tested this on my own Rails apps (4.2+) and it's working.
Mimicks: #35 - not meant to step on any toes, I didn't look at this pull request before making my own :\