Allow post <xs:id> to be 0 #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WXR is a format defining export and import.
During a WordPress export 0 is not a valid value.
But an import may originate from a non-WordPress source (eg: another CMS).
In most case such posts will be numbered too what would easily map to WordPress
<xs:id>.But in WordPress, (file) attachments are also WP_post and attachment from incoming source may not having unique identifiers or identifiers not being integers.
Having to generate random integers is not logical.
That would makes sense to allow
<xs:id>to be 0 for imported WXR files.