[misc] fix a potential double free and avoid nonsensical error messages #315
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
name: VS2022 | |
on: | |
push: | |
paths-ignore: | |
- '.gitignore' | |
- '.gitattributes' | |
- 'res/**' | |
- '**.cmd' | |
- '**.md' | |
- '**.rc' | |
- '**.sh' | |
- '**.txt' | |
- '**.xml' | |
pull_request: | |
branches: [master] | |
paths-ignore: | |
- '.gitignore' | |
- '.gitattributes' | |
- 'res/**' | |
- '**.cmd' | |
- '**.md' | |
- '**.rc' | |
- '**.sh' | |
- '**.txt' | |
- '**.xml' | |
env: | |
SOLUTION_FILE_PATH: ./rufus.sln | |
BUILD_CONFIGURATION: Release | |
jobs: | |
VS2022-Build: | |
runs-on: windows-latest | |
strategy: | |
matrix: | |
TARGET_PLATFORM: [x64, x86, arm64, arm] | |
steps: | |
- name: Checkout repository | |
uses: actions/checkout@v4 | |
with: | |
fetch-depth: 0 | |
submodules: recursive | |
- name: Add MSBuild to PATH | |
uses: microsoft/setup-msbuild@v2 | |
with: | |
msbuild-architecture: x64 | |
- name: Set ALPHA | |
id: set_alpha | |
shell: bash | |
if: ${{ !startsWith(github.ref, 'refs/tags/') }} | |
# This ONLY works if the shell is bash or if using $env:GITHUB_OUTPUT | |
run: | | |
echo "option=/DALPHA" >> $GITHUB_OUTPUT | |
sed -b -i 's/VALUE "InternalName", "Rufus"/VALUE "InternalName", "Rufus (ALPHA)"/' ./src/rufus.rc | |
- name: Set BETA | |
id: set_beta | |
shell: bash | |
if: ${{ startsWith(github.ref, 'refs/tags/') && contains(github.ref, 'BETA') }} | |
# This ONLY works if the shell is bash or if using $env:GITHUB_OUTPUT | |
run: | | |
echo "option=/DBETA" >> $GITHUB_OUTPUT | |
sed -b -i 's/VALUE "InternalName", "Rufus"/VALUE "InternalName", "Rufus (BETA)"/' ./src/rufus.rc | |
- name: Build | |
shell: cmd | |
run: | | |
set ExternalCompilerOptions=${{ steps.set_alpha.outputs.option }} ${{ steps.set_beta.outputs.option }} | |
msbuild ${{ env.SOLUTION_FILE_PATH }} /m /p:Configuration=${{ env.BUILD_CONFIGURATION }},Platform=${{ matrix.TARGET_PLATFORM }},ForceImportBeforeCppTargets=%GITHUB_WORKSPACE%\.vs\Generate.PDB.props | |
move .\${{ matrix.TARGET_PLATFORM }}\Release\rufus.exe .\rufus_${{ matrix.TARGET_PLATFORM }}.exe | |
move .\${{ matrix.TARGET_PLATFORM }}\Release\rufus.pdb .\rufus_${{ matrix.TARGET_PLATFORM }}.pdb | |
- name: Display SHA-256 | |
run: sha256sum ./rufus_${{ matrix.TARGET_PLATFORM }}.exe | |
- name: Upload to VirusTotal | |
continue-on-error: true | |
if: ${{ github.event_name == 'push' }} | |
run: | | |
curl --request POST --url https://www.virustotal.com/vtapi/v2/file/scan --form apikey=${{ secrets.VIRUSTOTAL_API_KEY }} --form file=@./rufus_${{ matrix.TARGET_PLATFORM }}.exe | |
curl --request POST --url https://www.virustotal.com/api/v3/monitor/items --header 'x-apikey: ${{ secrets.VIRUSTOTAL_API_KEY }}' --form path='/rufus_${{ matrix.TARGET_PLATFORM }}.exe' --form file=@./rufus_${{ matrix.TARGET_PLATFORM }}.exe | |
- name: Upload artifacts | |
uses: actions/upload-artifact@v4 | |
if: ${{ github.event_name == 'push' }} | |
with: | |
name: ${{ matrix.TARGET_PLATFORM }} | |
path: | | |
./*.exe | |
./*.pdb | |
Extra-Step-To-Merge-Artifacts-Thanks-To-Upload-Artifact-v4-Breaking-Backwards-Compatibility: | |
runs-on: windows-latest | |
needs: VS2022-Build | |
steps: | |
- name: Merge Artifacts | |
uses: actions/upload-artifact/merge@v4 | |
if: ${{ github.event_name == 'push' }} | |
with: | |
name: VS2022 | |
delete-merged: true |