build(deps-dev): bump urllib3 from 1.26.16 to 1.26.17

[dependabot]

Bumps urllib3 from 1.26.16 to 1.26.17.

Release notes

Sourced from urllib3's releases.

1.26.17

• Added the Cookie header to the list of headers to strip from requests when redirecting to a different host. As before, different headers can be set via Retry.remove_headers_on_redirect. (GHSA-v845-jxx5-vc9f)

Changelog

Sourced from urllib3's changelog.

1.26.17 (2023-10-02)

• Added the Cookie header to the list of headers to strip from requests when redirecting to a different host. As before, different headers can be set via Retry.remove_headers_on_redirect. ([#3139](https://github.com/urllib3/urllib3/issues/3139) <https://github.com/urllib3/urllib3/pull/3139>_)

Commits

• c9016bf Release 1.26.17
• 0122035 Backport GHSA-v845-jxx5-vc9f (#3139)
• e63989f Fix installing brotli extra on Python 2.7
• 2e7a24d [1.26] Configure OS for RTD to fix building docs
• 57181d6 [1.26] Improve error message when calling urllib3.request() (#3058)
• 3c01480 [1.26] Run coverage even with failed jobs
• See full diff in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

---

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
• @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  You can disable automated security fix PRs for this repo from the Security Alerts page.

[dependabot]

Superseded by #1631.

[pazz]

These kind of PRs look useful but it appears that they are bumping the minimal requirements without saying why this is necessary.
A counter-argument would be to keep the requirements as old as possible, so that they are not always too new for distributions to include alot.
Comments?

[lucc]

It looks like the bot is only bumping the locked version and not the version constraint we have in the pyproject.toml file. This would mean that we should probably use some sem-ver compatible version specification for our dependencies (https://python-poetry.org/docs/dependency-specification/).

This way we can get mostly security fixes from the bot and upgrading in some incompatible way would then be a human interaction.

About "as old as possible": I think that philosophy is good for code compatibility so that we should not rewrite alot to use new python syntax or major package versions just for fun. But if we see some benefit in doing so, we should still do it! Any distro that can not ship the new dependencies we require just needs to ship an old version of alot.

[pazz]

Thanks for this. I agree that this is a good way forward. Quoting Lucas Hoffmann (2023-11-13 17:39:15)

…

It looks like the bot is only bumping the locked version and not the version constraint we have in the pyproject.toml file. This would mean that we should probably use some sem-ver compatible version specification for our dependencies (https://python-poetry.org/docs/dependency-specification/). This way we can get mostly security fixes from the bot and upgrading in some incompatible way would then be a human interaction. About "as old as possible": I think that philosophy is good for code compatibility so that we should not rewrite alot to use new python syntax or major package versions just for fun. But if we see some benefit in doing so, we should still do it! Any distro that can not ship the new dependencies we require just needs to ship an old version of alot. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.*Message ID: <pazz/alot/pull/1629/ ***@***.***>