build: added pyproject.toml #1621
Conversation
|
nice, cheers! |
|
sure, do you mean the "contributing" section about running tests ? any other places you have in mind |
|
I thought there was already some part in the docs where we mention pip, but I cannot find it now.
Was thinking of here https://alot.readthedocs.io/en/latest/installation.html
Just wanted to make sure that all suggestions for installation paths are in the same place..
Cheers!
P
Quoting Matthieu Coudron (2023-05-22 10:02:47)
… sure, do you mean the "contributing" section about running tests ? any other
places you have in mind
what about the setup.py ? shall it be kept during the transition to smooth
things out ( I think so) ?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.*Message ID: <pazz/alot/pull/1621/
***@***.***>
|
The 'setup.py' approach is hardly automatable, which is why the python ecosystem currently discourage it peps.python.org/pep-0518 . The pyproject.toml can be parsed by 3rd-party tools while addressing shortcomings of setup.py (can create a sandbox a la pipenv). `poetry install`
we need python3-dev (for pyconf.h) and swig for the python gpg dependency
I was able to generate the doc via 'poetry run make -C docs html'
|
I haven't updated the instructions to generate the documentation since |
|
I am not at all familiar with poetry and don't really have the time to read up. About the sphinx docs: when you build them this way, is this also generating the list of commands correctly? These are separate scripts in our doc build process.. |
|
thank you sorry I was not sure how to answer. If you have trouble with the recent merge let me know and I'll try to address the issues. |
|
No worries, and thanks for the PR.
Do you have an opinion about how to deal with the bot-suggested version
bumps? Can we simply allow them in? It looks alright to me..
P
Quoting Matthieu Coudron (2023-07-26 14:15:13)
… thank you sorry I was not sure how to answer. If you have trouble with the
recent merge let me know and I'll try to address the issues.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you modified the open/close state.*Message ID:
***@***.***>
|
which one ? |
|
ha this #1623 ? probably fine |
|
Quoting Matthieu Coudron (2023-07-28 12:46:15)
ha this #1623 ? probably fine
Yes thanks.
More generally I have not seen these automatic PRs before and wanted your take on them.
Thx
|
|
This PR didnt change the settings so it must have preexisted. Feel free to disable dependabot in gitlab settings. We can accept those automated PRs only if we are confident in the testuite but it seems we run none :s |
The 'setup.py' approach is hardly automatable, which is why the python ecosystem currently discourage it peps.python.org/pep-0518 . The pyproject.toml can be parsed by 3rd-party tools while addressing shortcomings of setup.py (can create a sandbox a la pipenv).
poetry install