Merge pull request #75 from paytrail/fixRequestSettlementsUrlParameters

Fix requestSettlements url parameters
paytrail · Apr 19, 2023 · 1b1c293 · 1b1c293
2 parents ed22be2 + 713c86a
commit 1b1c293
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/src/Client.php b/src/Client.php
@@ -631,6 +631,12 @@ public function requestSettlements(SettlementRequest $settlementRequest)
 
         $uri = '/settlements';
 
+        $query = http_build_query($settlementRequest->jsonSerialize());
+
+        if (!empty($query)) {
+            $uri .= '?' . $query;
+        }
+
         return $this->get(
             $uri,
             function ($decoded) {

diff --git a/tests/ClientTest.php b/tests/ClientTest.php
@@ -493,6 +493,12 @@ public function testRequestSettlementsWithInvalidDateThrowsException()
     }
 
     public function testRequestSettlementsReturnsValidResponse()
+    {
+        $settlementRequest = (new SettlementRequest());
+        $this->client->requestSettlements($settlementRequest);
+    }
+
+    public function testGetSettlementsReturnsValidResponse()
     {
         $settlementRequest = new SettlementRequest();
         $settlementResponse = $this->client->requestSettlements($settlementRequest);