Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update resume flow return value parameter names #2461

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

ravishekhar
Copy link
Contributor

@ravishekhar ravishekhar commented Jan 10, 2025

Description

As per latest discussions the return URL would be as below

https://example.com/redirectUrl#onApprove?token=ABCDED&PayerID=SDFFF23232

This PR updates the return url parsing logic as per above contract.

Why are we making these changes? Include references to any related Jira tasks or GitHub Issues

Reproduction Steps (if applicable)

Screenshots (if applicable)

Dependent Changes (if applicable)

Groups who should review (if applicable)

❤️ Thank you!

@ravishekhar ravishekhar requested a review from a team as a code owner January 10, 2025 18:29
@ravishekhar ravishekhar marked this pull request as draft January 10, 2025 18:37
@ravishekhar ravishekhar marked this pull request as ready for review January 10, 2025 19:46

const {
token,
PayerID,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh they are doing PayerID and not payerID?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll have to do a new PR too

@ravishekhar ravishekhar merged commit df7a515 into main Jan 14, 2025
5 checks passed
@ravishekhar ravishekhar deleted the update-resume-contracts branch January 14, 2025 15:35
muntahafayiz

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants