This repository has been archived by the owner on Dec 13, 2018. It is now read-only.
Add built in glamorous components #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #297 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 10 10
Lines 170 170
Branches 46 46
=====================================
Hits 170 170Continue to review full report at Codecov.
|
luke-john
previously approved these changes
Aug 21, 2017
| * HTMLDetailsElement, HTMLDialogElement, | ||
| * HTMLKeygenElement, HTMLMenuItemElement | ||
| * Those components currently has wrong type. | ||
| * After TypeScript add those types, plz fix this. |
There was a problem hiding this comment.
Would you mind adding a link to the tracking issue for this to the comment.
There was a problem hiding this comment.
@luke-john I added it. Thank you for notifying me!
luke-john
approved these changes
Aug 22, 2017
kentcdodds
approved these changes
Aug 22, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Built-in component other than
DivandSvgis originally not available in TS.Why: Of course, in TS, we needs other built-in components.
How: Follow #294 (comment)
Checklist: