Improve IllegalArgumentException if "version to" is older than current version #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabiocarvalho777
requested changes
Oct 30, 2020
butterfly-core/src/main/java/com/paypal/butterfly/core/UpgradePath.java
Outdated
Show resolved
Hide resolved
butterfly-core/src/main/java/com/paypal/butterfly/core/UpgradePath.java
Outdated
Show resolved
Hide resolved
butterfly-core/src/main/java/com/paypal/butterfly/core/UpgradePath.java
Outdated
Show resolved
Hide resolved
butterfly-core/src/test/java/com/paypal/butterfly/core/UpgradePathTest.java
Outdated
Show resolved
Hide resolved
butterfly-core/src/test/java/com/paypal/butterfly/core/UpgradePathTest.java
Outdated
Show resolved
Hide resolved
butterfly-core/src/test/java/com/paypal/butterfly/core/UpgradePathTest.java
Outdated
Show resolved
Hide resolved
Current exception message doesn't provide much information about the problem. The exception message has been improved to provide the root cause
fabiocarvalho777
approved these changes
Nov 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #214 .
I have used
Gradle-Corelibrary'sVersionNumberclass to compare thecurrentVersionandupgradeVersion.I have also added three test cases.
Please let me know if anything needs to be changes.
Thank you.